Battery-Intelligence-Lab / galv

An open-source platform for automated storage of battery data with advanced metadata support
https://battery-intelligence-lab.github.io/galv/
Other
33 stars 8 forks source link

Yarn vs NPM #10

Closed pghege closed 2 years ago

pghege commented 2 years ago

Is your feature request related to a problem? Please describe. I notice some modules are using yarn while others are using npm. This discrepancy may cause build failure in the future. Under galvanalyser frontend uses yarn in Dockerfile_dev but npm in Dockerfile. Additionally there is a yarn.lock file present in the directory which suggests Yarn is preferred. Should the prod Dockerfile be changed to use yarn?

Describe the solution you'd like To rely on one build tool. I have slight preference for Yarn but just looking for clarity and consistency

martinjrobins commented 2 years ago

thanks for this @pghege. Yes, I was indeed aiming for yarn, so I'll update frontend/Dockerfile