search

Battery-Intelligence-Lab / galv

An open-source platform for automated storage of battery data with advanced metadata support
https://battery-intelligence-lab.github.io/galv/
Other
33 stars 8 forks source link

Deleted dependency detected #122

Closed ashishbijlani closed 10 months ago

ashishbijlani commented 10 months ago

I'm a Cyber Security researcher and developer of PackjGuard [1] to address open-source software supply chain attacks.

Issue

During my research, I found that this repo is vulnerable to attack due to deleted dependency from the public PyPI registry.

Details

Specifically, file https://github.com/Battery-Intelligence-Lab/galv/blob/613e359fe33c18592580a8ae91a352640f1707d0/harvester/requirements.txt lists vani as one of the dependencies. However, it has been deleted from public PyPI. As such, an external bad actor can claim that name and register a malicious package, which will be then installed with pip install command, resulting in arbitrary remote code execution.

Impact

Not only your apps/services using https://github.com/Battery-Intelligence-Lab/galv repo code are vulnerable to this attack, but the users of your open-source Github repo could also fall victim.

You could read more about such attacks here: https://medium.com/@alex.birsan/dependency-confusion-4a5d60fec610

Remediation

Please manually register a placeholder vani package on PyPI immediately or remove vani dependency from https://github.com/Battery-Intelligence-Lab/galv/blob/613e359fe33c18592580a8ae91a352640f1707d0/harvester/requirements.txt to fix this vulnerability.

To automatically fix such issues in future, please install PackjGuard Github app [1].

Thanks!

  1. PackjGuard is a Github app that monitors your repos 24x7, detects vulnerable/malicious/risky open-source dependencies, and creates pull requests for auto remediation: https://github.com/marketplace/packjguard
ashishbijlani commented 10 months ago

This looks like a false positive. Sorry about this. Please ignore.