search

Battery-Intelligence-Lab / galv

An open-source platform for automated storage of battery data with advanced metadata support
https://battery-intelligence-lab.github.io/galv/
Other
33 stars 8 forks source link

#47 frontend-dev runs yarn install on docker-compose up #57

Closed martinjrobins closed 1 year ago

martinjrobins commented 1 year ago

Fixes #47

martinjrobins commented 1 year ago

in a production env node_modules is in /usr/share/nginx/html so this won't be a problem. In fact I'm not sure why this mapping is in the prod docker-compose file:

    volumes:
     - ./frontend:/app

Should this be only in the dev docker-compose?

martinjrobins commented 1 year ago

I tried prod deploy and seems to work ok, merging....