search

BattlePro / battlepro-issues

1 stars 0 forks source link

Matches without a banner used to show game logo #123

Closed mikecreuzer closed 6 years ago

mikecreuzer commented 7 years ago
screen shot 2017-09-18 at 2 05 18 pm
Ian-Hitt commented 7 years ago

@mikecreuzer it is using a loop, and adding a class like so: bp_tournamentBanner bp_tournamentBanner--iconBanner bp_icon bp-gameLogo-7

Needs add-on update to support image for game. That way when there is no image in the db, we can set a default.

Ian-Hitt commented 7 years ago

requires: https://github.com/BattlePro/battlepro-issues/issues/122

Ian-Hitt commented 7 years ago

@mikecreuzer Can't don't have anything to check, so can't set a default logo

using this currently

                <span class="bp_tournamentBanner bp_tournamentBanner--imageBanner" style="background-image: url(data/battlepro/tournament/banner-{$tournament.tournament_id}.jpg)"></span>
            <xen:else />
                <span class="bp_tournamentBanner bp_tournamentBanner--iconBanner bp_icon bp-gameLogo-{$tournament.game_id}"></span>
            </xen:if>
Ian-Hitt commented 7 years ago

it sets a default logo for games that have a logo uploaded, but no way to know if one is uploaded or not