search

BattlePro / battlepro-issues

1 stars 0 forks source link

Change Tournaments to use first stage for number of players #232

Closed kylerc closed 6 years ago

kylerc commented 6 years ago

Currently is using the info from the game info page.

JakeBooher commented 6 years ago

I've looked into this and there is quite a bit using this value. Could we make the first stage inherit from the tournament value instead?

kylerc commented 6 years ago

@JakeBooher might be easier to just have the saving of stages get this value and apply it to the tournament itself? Could we do the same thing to the start time for the tournament?

JakeBooher commented 6 years ago

@kylerc just realized something, are we talking about number of players or number of teams? I'm not sure how number of players per team is relevant to stages and this value is used for several other things before the stage page is accessed. Number of teams on the other hand shouldn't be a major change

kylerc commented 6 years ago

Sorry, correct number of teams not number of players. You should also be able to get the start time and date from the first stage and apply those.

JakeBooher commented 6 years ago

Alright, that won't be an issue then 👍