BattleScribe / Release

Bug tracking for the release (live) version of BattleScribe
13 stars 2 forks source link

Alternate repo sources #155

Open Jonskichov opened 4 years ago

Jonskichov commented 4 years ago

Allow users to add additional repository sources to the app. Initially this does not need to be full-featured. First iteration should be focused on letting amis92 test the new GitHub hosted repository system and potentially repository "Gallery"

My first thought is to add a button to the Repository Source window (shown when clicking "ADD DATA" from the Manage Data window) to allow users to add a source via a URL. The Repository Source window could show all sources as tabs.

https://github.com/WarHub-Warden-testrepo/registry/releases/download/index-v1/bsdata.catpkg-gallery.json

amis92 commented 4 years ago

@Jonskichov bump bump.

Any chance you'll prioritize this soon? I'm feeling kinda blocked on moving further with that whole registry story.

Jonskichov commented 4 years ago

@amis92 Shouldn't be long now.

I had to make sure everything was happy and stable with the new version first - there's always a batch or two of bugs after a big change.

Things are looking stable now (fingers crossed), so I'm going to start work on that new feature release for the data authors next (including this issue) :)

I'm thinking I'll put together a list of issues/features that I intend to include in the release so you lot are informed of what to expect.

amis92 commented 4 years ago

I do like your more public workflow a lot.

I have no idea how much work every release is, but if this isn't that much, would you consider pushing this out separately?

Jonskichov commented 4 years ago

I'm working on it right now :) If there's any other easy bits to do, I'll get them done too and get a release out soon.

In my testing, the repositorySourceUrl in your json is incorrect

You have: https://github.com/WarHub-Warden-testrepo/registry/releases/downloads/latest/bsdata.catpkg-gallery.json

It should be: https://github.com/WarHub-Warden-testrepo/registry/releases/latest/download/bsdata.catpkg-gallery.json

(https://help.github.com/en/github/administering-a-repository/linking-to-releases)

amis92 commented 4 years ago

It should indeed! I'll update it. Edit: updated. Should now contain correct link.

Jonskichov commented 4 years ago

Thanks for your change.

Turns out, your whole system seems to be working well. I can add your repo source, list the repos it contains, add/remove those repos, and download data from them. Well done :)

I've put out a beta so you can do any testing you need to do on your end: