BattleScribe / Release

Bug tracking for the release (live) version of BattleScribe
13 stars 2 forks source link

Roster view displays one of multiple distinct profiles with the same name #25

Open ThePatient opened 6 years ago

ThePatient commented 6 years ago

Issue: Looking at a unit in roster view that has missile attacks with the same name as melee attacks causes only one of them to be displayed, not both.

Reproduction:

1) Create a new roster using the Stormcast Eternal catalog. 2) Add a Knight-Venator or unit of Prosecutors. 3) If you added a unit of prosecutors, select one of the options with the celestial hammer(s). 4) Select View. 5) Notice that for a Knight-Venator unit, there is a missile version of Celestial Beak and Talons listed, but the melee version of Celestial Beak and Talons is not. For Prosecutors outfitted with Celestial Hammer(s) the melee version is displayed but not the missile.

Expected Result: Both the missile and melee versions of the unit's attacks are displayed.

NOTE: I have not tested this on platforms other than iOS or with another data set other than the default Stormcast Eternal cat (https://github.com/BSData/warhammer-age-of-sigmar), but I did take a look at the data file to verify that both of the celestial hammer(s) attacks are present and appear to be hooked up correctly.

amis92 commented 6 years ago

Please change the title to a more generic one, like "Roster view displaying one of multiple distinct profiles with the same name"

It's most probably an issue that'll be resolved by the datafile (I hope you've raised an issue there), and response time here is going to be rather long. However, it might be resolved at some point in future. 😅

morvael commented 6 years ago

This whole aspect of BattleScribe needs some rework. Authors really need the to option to customize output of stat tables. There is a need of multiple lines composite stat tables, and custom ordering instead of alphabetical.

amis92 commented 6 years ago

@morvael, what do you mean by "multiple lines composite stat tables"?

morvael commented 6 years ago

It would be great to be able to output several profile instances of one or more profile types specified by entry as one entity. For example a ship in Dropfleet Commander is described by 1 ship profile, 0-4 weapon profiles, and 0-1 launch profiles (example). Currently Battlescribe mixes all ship profiles, all weapon profiles, and all launch profiles in three tables. This doesn't allow you to find out which ship has which weapons, unless you go the ugly way I went when creating data files for that game (check them out) - by prefixing every weapon name with ship class name and a letter to maintain order and keep references. It would be great if it would be possible to somehow link those multiple profiles of a single entry, so that BS would know whether to display them together.

amis92 commented 6 years ago

"What has what" is solved by child selections, not really sure what you're talking about. Having all profiles bundled together per root selection has always been the case and here also I'm not sure I follow what is wrong with that.

All in all, this discussion is rather off-topic, if you want to explore it further please open new issue for this specific case.

morvael commented 6 years ago

Well, I thought this is related because this issue is also about multiple profiles per item. Don't want to introduce child selections, a single selection (ship) comes with multiple profiles, simple as that.

amis92 commented 6 years ago

@morvael Profiles themselves are ephemeral entities that do not exist "on their own". If a ship has a weapon, it should be constructed in catalogue as:

That way, in Roster View, you can see what weapons a given ship has, and find profiles of these weapons either in summary, or just below entry, depending on view settings you set.

amis92 commented 6 years ago

@morvael I think what you actually want and might be done, is adding output setting that adjusts level at which profiles and rules are rooted:

This would decide whether all descenant selections (upgrades/models) are grouped at root selection level (current behavior), or somewhere deeper (what you'd want is probably model level). Innermost unit level would make a difference for nested groups of units.

That might be viable for implementation, and actually allow everyone better adjustement of roster display/print.

Can you post that as a separate issue?

morvael commented 6 years ago

If a ship has a weapon, it should be constructed in catalogue as

I guess this BS's feature comes from development concentrating on supporting games where you can select weapons for models/units. Here, a ship always has the same weapons, they are not optional, so multiplying entries just to keep profiles in order seems like overkill. I guess I have to alter my Dropfleet files to use this feature and get a pretty grouping of profiles :)

I'll try to open new issue following your suggestion. With this one setting I could get profiles to work as desired, without adding hundreds of entries.

amis92 commented 6 years ago

Regarding duplication, Dropfleet files have a lot of duplicate shared entries, not sure why, but that's completely off-topic.

morvael commented 6 years ago

Maybe you mistake group of ships with a single ship? I made it that way so that it would look nice in the editor (with checkboxes instead of spinner). All is needed because of how the composition rules work. You don't select single ships to include in your fleet for a normal game (I've added ship browser mode only for fun). You select battlegroups, which have to be composed of certain groups (medium, light) which can have ships of specific tonnage inside, and the ships themselves can be taken in multiples in case of smaller ships, while still being a single group. And I wanted to have each ship as a separate model, because that allows you to name them all in BS :)

ThePatient commented 6 years ago

I figured I would raise it here since it's a systematic issue that could save data authors a ton of effort moving forward, but I understand that the data fix is quite a bit easier.

I wanted to see what the response was before I raised the issue over there. I will raise it now.