search

Battler45 / SierraMigrationToGitHub

Migration from unfuddle to GitHub
0 stars 0 forks source link

Create "Edit Global Site Settings" page. #173

Open Battler45 opened 4 years ago

Battler45 commented 4 years ago

Aman, I've created a template (attached) for a new page, "account-site-settings.htm" . This page is very similar in functionality to the first page you created, almost identical, except that different fields in the Sites table get updated. Please name your page "account-site-settings.aspx"

In terms of security & access, with the sites drop-down, etc., all will be exactly the same as on the first page.

Please map the form fields to the Sites DB table using the following scheme:

  • New Listings Email Alert Subject: AlertSubject
  • Contact Us Text: ContactUsText
  • Registration Requirement: RequireRegistration
  • Num of Detail Views Before Requirement: NumDetailViewsBeforeRegistration
  • Require Phone Number: RequirePhoneNumber
  • Send Leads to Text Message: SendLeadsToTextMessage
  • Text Message Email Address: TextMessageEmailAddress
  • Send BCC on Email to Friend: SendBCCOnEmailToFriend
  • Enable Top Producer Integration: TopProducerEnabled
  • Top Producer Restrictions: TopProducerSendType
  • Top Producer Assigned To: TopProducerAssignedTo
  • Top Producer Unique ID: TopProducerUniqueID
  • Enable Salesforce.com Integration: SalseforceEnabled
  • Salesforce.com Restrictions: SalesforceSendType
  • Salesforce.com Org ID: SalesforceUniqueID
  • Meta Title: MetaTitle
  • Meta Keywords: MetaKeywords
  • Meta Description: MetaDescription

In validating text fields such as MetaTitle, MetaDescription, EmailAlertSubject, etc., please also be sure to validate (javascript) against the length of the field, as compared with the allowed varchar() value for the field in the database. Meaning for example, for ContactUsText, do not accept form inputs longer than 512 chars, as this is the length of the field in the DB.

Required fields are marked with a red asterisk.

Please let me know if you have any questions. Thanks.

Posted by Peskoe Ben(unfuddle username: bpeskoe)

Battler45 commented 4 years ago

Aman,

Regarding radio buttons, I don't believe validation is necessary -- in cases where there is not data for the current recordset, please always default the first option to be selected. That way, at least one value for each radio button will always be selected, and there will not be a chance that the form could be submitted without radio button values.

Regarding text field length validation -- Vihar, I apologize, I forgot to mention this to you -- in all cases, please validate max length of text form fields to whatever is the length of the corresponding column in the database. Can this type of validation be implemented via JQuery Tools? If not, it is fine to set a MaxLength property on the text field itself. Posted by Peskoe Ben(unfuddle username: bpeskoe)

Battler45 commented 4 years ago

Ben , Vihar

I have implemented max length check on account-contact-info

Regards

Battler45 commented 4 years ago

Ben,

All pages except the account-contact-info pages are updated to set max-length validations. I've updated the development site to include latest changes. Pls test the same.

Aman - Pls update the account-contact-info page to set max-length validations on text-boxes. Pls note that I've updated both branches to include latest changes. Pls update your local branch.

Thanks Posted by Shah Vihar(unfuddle username: vshah)

Battler45 commented 4 years ago

Aman,

I have not had time to review and test this page in depth, but a couple of quick changes / fixes:

1 -- Please allow a 0 value for "Number of Detail Views Before Registration Requirement" -- please allow any value between 0 and 100.

2 -- I have been talking with Vihar about updating the javascript validation messages that appear and the way that they cover up the form label so that you cannot see what is being requested in the form field, and he is coming up with a way to make the javascript validation messages include the name of the field. Can you please follow up with him and then implement this same thing on both of the pages you have worked on?

3 -- On successful submit, the confirmation message slides in from the top, but for successful submit, the message should be displayed in blue (as on the User page), not in red. The red message color is typically only used to indicate an error.

Thanks. Posted by Peskoe Ben(unfuddle username: bpeskoe)

Battler45 commented 4 years ago

Ben,

I'll work on updating form-inputs to validate max. lengths. I'll check it in jQuery Tools, and update all form-inputs to validate against corresponding database columns' size.

Thanks Posted by Shah Vihar(unfuddle username: vshah)

Battler45 commented 4 years ago

Ben,

RE point 2 in above comment - I've updated both these pages to display field-names in error messages. So as far as changes in validations are concerned, Aman only needs to update the account-contact-info page to set max-length validations.

Thanks. Posted by Shah Vihar(unfuddle username: vshah)

Battler45 commented 4 years ago

Aman,

Also, please validate "Num Detail Views Before Requirement" text field to only accept whole numbers greater than 0.

Thanks. Posted by Peskoe Ben(unfuddle username: bpeskoe)

Battler45 commented 4 years ago

Vihar, thanks, please let me know when this is done, and please let me know when you have posted Aman's changes to the development site for testing and review.

Posted by Peskoe Ben(unfuddle username: bpeskoe)

Battler45 commented 4 years ago

And also , how about required validation for radio buttons. have we done it somewhere

Battler45 commented 4 years ago

No such validations are performed in existing code. Posted by Shah Vihar(unfuddle username: vshah)

Battler45 commented 4 years ago

Ben, Vihar

Have we put a max length check on any page?