BattletechModders / CBTBehaviorsEnhanced

Applies Classic BattleTech behaviors to the HBS BattleTech Game
MIT License
5 stars 6 forks source link

Heat dialog does not correctly display potential heat #41

Closed IceRaptor closed 4 years ago

IceRaptor commented 4 years ago

From #closed-3429 on RT discord:

DrBwaa reporting.

===== WEIRD OVERHEATING =====

Same battle, a turn or two later. A mostly pristine mech just suddenly decided not to sink most of its heat. Three screenshots incoming, then logs. Just showing my loadout and location. Nowhere near fire, haven't moved or anything.

See https://cdn.discordapp.com/attachments/697343158467428433/697664161534181426/Unexpected_Overheating_2.png

.I still get this issue every mission or two. Anything else y'all need from me? I can keep sending logs if there's any chance it'll be helpful Interactive Rubber Dolphin04/14/2020 We are waiting on frosty to get some time to check it out DrBwaa04/14/2020 :thumbsup: I'll stay attached for the time being then. Thanks y'all. FrostRaptor04/14/2020 So the bug specifically is that the text only shows a sinking of -9, but the heatbar is working correctly? @DrBwaa is that correct? DrBwaa04/14/2020 @FrostRaptor The bug is that there's no reason this mech should only be sinking -9 instead of -39. About half the time when I get this, I seem to sink my full amount anyway. The rest of the time (as above), I only sink whatever the estimate tells me I will, gaining lots of net heat that I shouldn't be gaining. FrostRaptor04/14/2020 Hurm, okay Are you noticing any similarities between the two different cases? Like, the first case happens when you don't go through fire, the second when you do, etc If not, no problem - just grasping for straws here. The code in question is fairly complex and works between my code and CAC. DrBwaa04/14/2020 No, it seems to be completely random. It does tend to only happen on mechs running LRMs (that I've noticed), but nothing else seems to make a difference. Often they haven't even moved. It's possible I only notice it on my longer range mechs just because they are normally nowhere near fire or enemies so when they have heat problems it's really obvious that something is wrong. FrostRaptor04/14/2020 Hurm, okay. Thank you for the details, they are very helpful! DrBwaa04/14/2020 Sure thing! Do you want me to keep CBTBE debug on and send more logs, or not worry about it? FrostRaptor04/15/2020 You can flip it off Debug. I have enough information to start working through the code.

IceRaptor commented 4 years ago

From #closed-3499 on RT discord

The 85% Reduction of the potential Heat sinking is calculated from the generated heat instead of the potential 60+

https://cdn.discordapp.com/attachments/699758689057505351/699758902304178226/Heat.jpg

I recieve Overheat damage, without being overheated But the Heat I recieve is different, like it should be Interactive Rubber Dolphin04/15/2020 Yes, displayed heat prediction is wrong sometimes, we investigating it if you can find a pattern when it happens it would help FrostRaptor04/15/2020 Will sink in this case indicates your sink capacity i.e. you would sink -35 because you're in a .9 spot, instead of -51 in a 1.0 spot FrostRaptor04/15/2020 That's still wrong because it should be -46 sink capacity, so something's screwy there. Icebeard04/15/2020 Usually it happens when my Mechs getting additional heat, such as heat inducing landmines. I tried to repruduce it, but there were no landmines until now.

IceRaptor commented 4 years ago

This may be fixed with a clamp on overheat that was introduced in 5.0

IceRaptor commented 4 years ago

Cleaned up some heat testing semantics in 0.5.9