search

BattletechModders / LootMagnet

BattleTech Game mod that makes salvage suck less
MIT License
11 stars 7 forks source link

Allied status overrides reputation #4

Closed peterdettman closed 4 years ago

peterdettman commented 5 years ago

Helper.cs has the following code:

            // Check for allied
            if (State.IsEmployerAlly) {
                cfgIdx = 7;
            }

It seems a little generous for the employer to not distinguish high-rep allies from ones who have "strayed". I propose it be changed to simply give a +1 column shift:

            // Check for allied
            if (State.IsEmployerAlly) {
                ++cfgIdx;
            }
IceRaptor commented 4 years ago

Allying is a binary flag - you either are allied, or you aren't. The game doesn't treat Ally as the end of the spectrum for reputation points, it's a either/or situation. So doing what you propose would lead to weird results, where you are allied in the UI, but using the friendly rep values.

As such, I'm going to leave as is.