search

BattletechModders / PanicSystem

Simulates mechwarrior panic and automatic ejections
The Unlicense
4 stars 7 forks source link

Panic Ejections may be showing as multiple kills #6

Closed IceRaptor closed 4 years ago

IceRaptor commented 4 years ago

As per #rogueticket-456:

Just played a duo duel and killed one+ejected 1 enemy mech the mission report shows 1 kill+3 ejections

cleaned_output_log.txt unknown

fmnatic commented 4 years ago

I can reproduce this on duo duels, even when there are no ejections (2 kills). Seems to be an attempt to make the kills+ejections total to 4 somewhere. Don't see anything relevant in panicsystem. This may be a duel implementation thing?

fmnatic commented 4 years ago

Possibly related in Panic system

// TODO count kills recorded on pilot history so it's not applied twice

fmnatic commented 4 years ago

added double counting check, under test.

fmnatic commented 4 years ago

bug fixed in the PanicSystem UI layer. Each pilot was getting the ejection count of the previous pilot added up.

xeryx01 commented 4 years ago

The main problem is that pilots not getting kills, are showing them. It is almost a display glitch but there must be something more to it, but it worked before! nokill

fmnatic commented 4 years ago

Yeah , no idea at what point the bug was introduced, but its been there for the couple of months since i've been playing.

I have it fixed on my fork. Whats happening is for pilots with zero ejections, the number from the last pilot with ejections is used, even across missions.

xeryx01 commented 4 years ago

THank you fmnatic for updating the mod, it seem salso the delay that was occuiring when ejection occurs is also gone

fmnatic commented 4 years ago

this was fixed in 4.1.0