BauhausLuftfahrt / MATSim-UAM

Extension for MATSim to allow for the inclusion of aerial passenger-carrying vehicles, i.e. a station- and network-bound transport mode that requires station access and egress trips with conventional ground-based modes.
https://bauhausluftfahrt.github.io/MATSim-UAM/
GNU General Public License v3.0
21 stars 28 forks source link

Update example #62

Closed balacmi closed 3 years ago

sebhoerl commented 3 years ago

Well it doesn't need to be Corsica, but some meaningful test should be there, otherwise every time we refactor or change something we do it blindly :)

balacmi commented 3 years ago

Hey Raoul,

I have removed a lot of stuff from the config in the examples, as the config included everything. However, I cannot invest time now to only include the "needed" stuff. Do you have the time to do that? Or make an issue that should solve this in the future?

RRothfeld commented 3 years ago

Can it then be put into /examples/ in an appropriate folder? Still, I believe it should be run-able with the default run class.

What about the config, most default values don't have to be repeated, surely? I don't mind Corsica's config including everything.

sebhoerl commented 3 years ago

But test/resources is a standardized folder while examples is some random folder next to the standard layout. I'm not sure how to reliably reference the files in there from the unit tests. Things that are used as a unit test should be available as a test resource to make use of resource resolution etc.

RRothfeld commented 3 years ago

Fine, do as you please. I just kindly ask you to clean up once you are done. I had spent quite some time to remove scenario-dependent code and would prefer that scenario-dependent code does not float about in the master branch.

sebhoerl commented 3 years ago

Ok maybe there is a misunderstanding about the purpose. This scenario is used in a unit test that needs to pass before anything can be merged to the repository. Ideally, this would be even automatically. I think I cannot activate Travis for this repository here (it's probably on the organization level). Then you could only merge anything once the tests (unfortunately, now we only have this one) have all passed. So all the files to run the test case are included in the repository. Corsica is just an example for now, we can replace it with some generic "TestScenario" on a grid or something like this. But surely there must be tests.