UAMLinkSpeedCalculator unused since update to MATSim 12

BauhausLuftfahrt / MATSim-UAM

Extension for MATSim to allow for the inclusion of aerial passenger-carrying vehicles, i.e. a station- and network-bound transport mode that requires station access and egress trips with conventional ground-based modes.

https://bauhausluftfahrt.github.io/MATSim-UAM/

GNU General Public License v3.0

20 stars 27 forks source link

UAMLinkSpeedCalculator unused since update to MATSim 12 #74

Closed RRothfeld closed 3 years ago

RRothfeld commented 3 years ago

It seems that UAM travel speeds are now based solely on link's freespeeds, see: https://github.com/BauhausLuftfahrt/MATSim-UAM/blob/b2acd6828c1ecd440dd3e0778302a783e460b000/src/main/java/net/bhl/matsim/uam/run/UAMModule.java#L91

https://github.com/BauhausLuftfahrt/MATSim-UAM/blob/master/src/main/java/net/bhl/matsim/uam/qsim/UAMSpeedModule.java and https://github.com/BauhausLuftfahrt/MATSim-UAM/blob/master/src/main/java/net/bhl/matsim/uam/qsim/UAMLinkSpeedCalculator.java are unsused during simulation, leading to UAM speeds being equal link freespeed.

Would you propose creating a new TravelTime implementation for UAM that does the job or do you have other ideas?

sebhoerl commented 3 years ago

I just had a quick look. Actually, are you sure that this was working properly lately? Looking at the history of UAMSpeedModule, the provider for QNetworkFactory was commented out already on 19 November 2019. So since then UAMLinkSpeedCalculator was not used anywhere.

Two options:

Either the speed is encoded in the network (which, I think, is probably the case right now?). However, then it is certainly not vehicle-dependent.
Put back in UAMLinkSpeedCalculator, then it can be made vehicle-depedent again (which, I suppose, was the major functionality of the calculator).

RRothfeld commented 3 years ago

Sorry, Sebastian, you are right of course. It was undetected from previous changes, not from MATSim v12; and yes, the idea is that it's vehicle dependent.

I'll have a look into reactivation, see branch https://github.com/BauhausLuftfahrt/MATSim-UAM/tree/issue-74