search

Bawnorton / BetterTrims

Add new armour trims and give each trim a unique feature.
12 stars 3 forks source link

[Bug Report] Amethyst doesnt gives me a potion buff #40

Closed vlad8599 closed 7 months ago

vlad8599 commented 7 months ago

Expected Behaviour I should see that my + potions(force, regeneration, etc.) working almost twice longer.

Actual Behaviour It doesnt have any effect, if you will check timer, you will see that potion have its usual duration time(like 21 second for a Regeneration 2 potion).

Steps to Reproduce Just add trim with amethyst to armor and you will see. Full armor set with amethyst.

What version of the mod are you using 2.2.3, but with Minecraft 1.20.4

Helpful Files Drag and drop these files here to help me figure out what broke. latest.log

Bawnorton commented 7 months ago

Amethyst doesn't increase the duration of the effect, it just gives positive effects a chance to not tick down a second. Time the effects externally and they'll last longer.

vlad8599 commented 7 months ago

Sorry, but what means "tick down"? Its not related to duration time? Can you explain, please?

Bawnorton commented 7 months ago

Every second there is a % chance that the duration of the potion effect doesn't decrease.

So instead of the potion effect going 5 -> 4 -> 3 -> 2 -> 1 -> 0, it can go 5 -> 4 -> 4 -> 3 -> 2 -> 2 -> 1 -> 0 making it last 7 seconds instead of 5.

vlad8599 commented 7 months ago

Its not related to time on timer?

Bawnorton commented 7 months ago

The time on the timer will go down slower. Give yourself resistance for 30 seconds, set a 30 second timer. Your timer will end about 10 seconds before the effect ends

vlad8599 commented 7 months ago

Just tested with a few different effects(resistance, glowing, poison). It doesnt work! 30 seconds timer - and no slowing down for positive or faster for negative effects. Here is a log. latest.log