Bawnorton / BetterTrims

Add new armour trims and give each trim a unique feature.
12 stars 3 forks source link

[Bug Report] Crash with Iris 1.7.10-snapshot for Distant Horizons #47

Closed jukarr closed 5 months ago

jukarr commented 6 months ago

Expected Behaviour The game should launch as per usual - it does so when Better Trims is disabled.

Actual Behaviour Game crashes, the crash report mentions the kiwi library mod

Steps to Reproduce

What version of the mod are you using 2.2.3

Helpful Files

crash-2024-03-29_14.59.33-client.txt latest.log

Bawnorton commented 6 months ago

The version of iris you are using is not compatible with better trims. I am gonna wait for the iris-dh development to become stable before officially supporting this version.

FallconTXoC commented 5 months ago

I can push a fix for you, Iris changed their namespace from net.coderbot to net.irisshaders and that's what making BetterTrims unable to find MixinGameRenderer_NightVisionCompat

Bawnorton commented 5 months ago

Yes I'm aware. See above comment for why I've not addressed this. If you are knowledgeable on how to conditionally apply mixins based on mod version feel free to add an additional mixin for the experimental iris builds (you can't just change the namespace as that would break compat with the current stable versions)

This is what the annotation based checker would look like: https://github.com/Bawnorton/Neruina/blob/d0802f5ed05c85ea432746979e5bcf0dac1e4b30/src/main/java/com/bawnorton/neruina/NeruinaMixinPlugin.java#L70-L95

I doesn't really make sense to support an experimental build because it's not unlikely that the target will change again

muon-rw commented 5 months ago

Iris 1.7.0 is now released.

Bawnorton commented 5 months ago

Fixed in 2.3.1