Bawnorton / BetterTrims

Add new armour trims and give each trim a unique feature.
12 stars 3 forks source link

elytratrims is incompatible with AllTheTrim and causes crashes #79

Closed Cindystick closed 3 weeks ago

Cindystick commented 3 weeks ago

Although BetterTrims is compatible with elytratrims and is also compatible with AllTheTrims (BetterTrims also creates effects for various special materials such as echo fragments, coal, slime balls and even progress interfaces), However, elytratrims and AllTheTrim were incompatible, and the game crashed directly. After logging in again, all the original forging templates and elywings disappeared

Bawnorton commented 3 weeks ago

Log please

Cindystick commented 3 weeks ago

[Uploading crash-2024-10-16_23.22.36-client.txt…]()

Cindystick commented 3 weeks ago

2024-10-16-7.log.gz latest.log

Cindystick commented 3 weeks ago

I opened another new save to test it, and it still collapsed. Although the elytra can normally attach ten materials that could be attached to the vanilla armor and better trims can function normally, meanwhile the armor can also attach various materials added by all the tirm and better trims can also function, once the elytra is attached to various materials added by all the tirm (such as echo fragments), it will collapse. That is, elytratrims and AllTheTrim are incompatible

Bawnorton commented 3 weeks ago

Update Elytra Trims to 3.5.4

Cindystick commented 3 weeks ago

I did so and updated the versions of the two modules to the latest version, but all the trims itself does not have version 1.21.1, only version 1.21. Is this why it is incompatible with the elytra trims module?

Bawnorton commented 3 weeks ago

no, all 1.21 mods are compatible with 1.21.1 and vice versa

Cindystick commented 3 weeks ago

I downloaded runtimetrims, a new pre-module, and updated all modules of trims type and all pre-modules to the latest version, which finally solved the crash problem. Now the elytra can be normally typed in all the trim(Materials other than ten minerals added). 2024-10-17_17 59 27

Bawnorton commented 3 weeks ago

If you enable the legacy renderer inside runtime trims does it render correctly? If not it's something I missed during testing

Cindystick commented 3 weeks ago

excuse me, how to enable the legacy renderer? For now, texture rendering of various materials is normal. Different colors appear because of different materials, and different patterns are displayed because of different armor pattern templates 2024-10-17_21 51 47 2024-10-17_21 52 05 2024-10-17_21 52 19 2024-10-17_21 53 31 2024-10-17_21 53 34

Bawnorton commented 3 weeks ago

Glad to see it's rendering correctly. Pause Screen -> Mods -> RuntimeTrims -> Settings. That is if you have modmenu installed, otherwise, you'll need to change the config file and restart. .minecraft/configs/configurable/runtimetrims.json5

Cindystick commented 3 weeks ago

屏幕截图(670) After opening the legacy renderer, I found that there was no difference, and the rendering effect was still the same

Bawnorton commented 3 weeks ago

Neat, so it all is working?

Cindystick commented 3 weeks ago

I think so, everything functions and rendering are normal

Cindystick commented 3 weeks ago

Sorry but there is one more thing to consider. Can you consider adding compatibility with trinkets modules? The trinkets module has added more equipment slots for players, such as belt slots (located at the leg guard) elytra slots (located at the breastplate), shulker box slots (also located at the breastplate). Currently elytra with armor trims can only play the function of armor trims when it is used in the vanilla breastplate field. Can items be placed in the extra elytra slot while the added functions of the elytratrims module can also be used normally?

Bawnorton commented 3 weeks ago

I'll look into it

Cindystick commented 3 weeks ago

Thank you, it's a great honor