search

Bawnorton / Configurable

Compile/Runtime config library that allows decentralised settings in a mod
4 stars 0 forks source link

Default config options #3

Closed skycatminepokie closed 2 months ago

skycatminepokie commented 2 months ago

Right now (1.1.1), it looks like the YACL defaults are the same as whatever is current (aka the undo button is the same as the reset button).

(this first get call)

public final class YaclScreenFactory {
    public static Screen create(Screen parent, Config config) {
        // ...
       .binding(Binding.generic(config.place_block_clip.default_end_offset.get(), config.place_block_clip.default_end_offset::get, config.place_block_clip.default_end_offset::set))

Example showing the issue

Bawnorton commented 2 months ago

Is that not the expected behaviour?

Bawnorton commented 2 months ago

Ah yeah you're right, I mis-read the docs. I'll change the impl

skycatminepokie commented 2 months ago

Awesome, ty! I was struggling to explain it xd

Bawnorton commented 2 months ago

Fixed in 1.1.2