search

Bawnorton / Neruina

A mod that prevents ticking related crashes from bricking worlds
MIT License
39 stars 3 forks source link

Game Crashed by Critical Injection Failure with Forge 1.20.1 - 47.2.20 #37

Closed Coraline774477 closed 6 months ago

Coraline774477 commented 10 months ago

Minecraft: 1.20.1 Forge: 47.2.20 Neruina - Ticking Entity Fixer: 1.3.0

After updating Forge to Forge 1.20.1-47.2.20 which fixed the missing patch for Item.InventoryTick that obviously breaks Neruina's common.mixins.json:PlayerInventoryMixin in the embedded core mod ExtraMixins.

When the game crashed there's no crash report BUT there is a log, so here's the log:

Log: https://gist.github.com/Coraline774477/3e4338ad52a4cd0be5a9dfbc458fa403

One more thing, since Lex may have fixed something that Neruina had fixed prier to 47.2.20 that whatever your patch was is possibly no longer needed and needs to be removed for 47.2.20 and newer. So for now I'll be downgrading forge to the previous version (47.2.19) till you resolve this issue with an update. Luckily I always keep the previous version of forge installed in my launcher for circumstances like this. Since I need this mod for circumstances with ticking entities from other mods or even the game itself sometimes when Mojang messes up something in one of the updates. Which means this mod is a crucial/vital performance mod for potentially fixing ticking entities, since I had ticking entity crashes before and they're not fun at all..

Bawnorton commented 10 months ago

This log is truncated

Coraline774477 commented 10 months ago

Truncated?

Bawnorton commented 10 months ago

Most of it is cut-off, there is no useful information in the portion you sent

Coraline774477 commented 10 months ago

Oh, now I know what it means, why though is cause the game crashed at the very beginning so the game didn't have enough time to log past where it crashed

Coraline774477 commented 10 months ago

Wtf? It is shorter than the one I saw when I was brought back to the launcher. However I read the one I saw and it had the vital info about a mixin that broke from Lex's fix in the latest version of Forge 1.20.1. I guess I'll need to let the game crash again so that I can copy the text and paste it in a new secret gist and send it here

Coraline774477 commented 10 months ago

Here's what I saw, I had to let the game crash again to get the popup that has a few options and one let's me open the logs and this is what showed up: https://gist.github.com/Coraline774477/f5376d5c228083a7a9db748500fd82f2

I had to physically copy and paste all of the text into that gist

Bawnorton commented 10 months ago

Ok I'll look into what forge is doing in more recent versions. This will likely get bundled with the next version I am working on which will release when 1.20.5 releases

Coraline774477 commented 10 months ago

That's great and all to hear but I ain't moving away from 1.20.1 just yet but I don't know if my current laptop can handle 1.20.4 and newer which is partially the reason why I remained on 1.20.1 for this long..

Btw what I meant by "Popup" was this: Screenshot (96)

Thanks anyways for taking the time to review my report as well as potentially taking a look at this and what forge is doing in more recent versions. Even if the fix is aimed for 1.20.4/5, plus I didn't felt like updating forge 1.20.1 to 47.2.20 anyways and now I have an actual reason not to update it so that I can continue to use this on 1.20.1. BUT that fix that Lex did might help with performance to some degree though..

Oh! One very last thing, even though I use TL Legacy (in the screenshot) for modded minecraft but I do have an official copy as a redeem thing from a friend on discord several years ago. Just letting you know about that but why use TL Legacy? Because of performance reasons and it has less background processes than the official launcher does anyways.

Bawnorton commented 10 months ago

I will aim to maintain full backwards compat for neruina back to 1.18.2 for future releases, provided that it is feasible

itsdinkd commented 10 months ago

Same happens to me on my pack im building, the log contains absolutely nothing useful. It crashes way too soon in the start up process without any indication however when binary searching. it came down to this mod.

i know you said youll look into it but just adding to the thread.

itsdinkd commented 10 months ago

AH this is why, most likely.

Forge 47.4.20 added this "- 47.2.20 Fix missing patch for Item.onInventoryTick. Closes #9812"

Coraline774477 commented 10 months ago

AH this is why, most likely.

Forge 47.4.20 added this "- 47.2.20 Fix missing patch for Item.onInventoryTick. Closes #9812"

I've already noted about that above, as he stated that the fix may be back ported to forge 1.20.1.

You have seen all of this conversation between me and Bawnorton, right?

jmadarg commented 9 months ago

Any update on this? ATM9 got updated recently to 47.2.20 and the servers I help running had some Ticking Entity crashes already (they were updated last night)

Bawnorton commented 9 months ago

I'll release when 1.20.5 is released as my current dev branch is intended to release for forge, neoforge and fabric at the same time, which should be in a few weeks. ATM is a forge pack and you can use the config located at <world>/serverconfig/forge-server.toml and turn on removeErroringEntities in the meantime

LKAice commented 9 months ago

Any update on this? ATM9 got updated recently to 47.2.20 and the servers I help running had some Ticking Entity crashes already (they were updated last night)

i had a simmilar problem, whatever i did, anything with forge 47.2.20 wasn't starting. At least thats what i thought. ATM 9 was running perfectly fine if i startet it trough ATLauncher. So its probably something with curseforge, havent figured it out yet

LKAice commented 9 months ago

Any update on this? ATM9 got updated recently to 47.2.20 and the servers I help running had some Ticking Entity crashes already (they were updated last night)

i had a simmilar problem, whatever i did, anything with forge 47.2.20 wasn't starting. At least thats what i thought. ATM 9 was running perfectly fine if i startet it trough ATLauncher. So its probably something with curseforge, havent figured it out yet

ok, a complete reinstall of curseforge including all cashes etc. and a fresh install of Curseforge / the monecraft plugin and the pack did the trick

DONT FORGET TO BACKUP YOUR SAVES AND OTHER PACKS!

jmadarg commented 9 months ago

@LKAice I'm not sure what you are talking about. The incompatibility of Neruina and Forge 47.2.20 is confirmed and servers will simply not start if they have that combination. The ticking entity crashes are something expected to happen from time to time in a modded environment, specially on servers with high playercount, and Neruina prevents them. As currently Neruina can't be used for 47.2.20 some ticking entity crashes may happen, which is the issue I have

katubug commented 8 months ago

As someone also having this issue, I just wanted to pop in and say thank you to everyone for helping to work this out! Especial thanks to Bawnorton for maintaining so many versions of the mod.

X-Hellfire-X commented 8 months ago

I am crashing yet im on forge 47.2.18

X-Hellfire-X commented 8 months ago

is there any way to fix it?

KhaosKhaos commented 7 months ago

Any news?

Bawnorton commented 7 months ago

Nothing changed, as mentioned above. I will be releasing the update that supports this when 1.20.5 is released as it is a complete overhaul of the mod. I have more testing to do for the upcoming features and this time-gap gives me some breathing room.

https://github.com/Bawnorton/Neruina/blob/stonecutter/CHANGELOG.md

KhaosKhaos commented 7 months ago

Cool btw great mod dude <3 thx a loooooooooooot

Coraline774477 commented 6 months ago

I wonder if I really was the first to report about this problem before everyone else started having the same problem weeks after I did when I updated to what was the latest version of forge 1.20.1 at the time (47.2.20).

Since it's been a little more than three months now at 47.2.30.

Knock on wood that I continue not to encounter any ticking entities but so far so good that I haven't ran into any for the past few months since I stopped using Neruina till it's 2.0 release in May which 1.20.5 is right around the corner now.

Bawnorton commented 6 months ago

Fixed in 2.0.0-beta.1

Coraline774477 commented 5 months ago

Yay! 2.0.0 (as of its 10th beta) is finally here! Can't wait to eventually get my hands on a copy of Neruina - 2.0.0 in full release or when it's stable enough. Also still knocking on wood that I still haven't ran into any ticking entities yet.

However, what I've been being bombarded with is bad server lag (TPS) for the past few months to more than 5 months now due to newer forge versions that Lex may have snuck in some fix or something that's causing most mods that were playable to now be unbearable to play with due the immense amount of server lag, such as GPU Memory Leak Fix causing high server lag when installed which that mod's being counterproductive to what it's supposed to be doing. That mod is making things worse than making things better for me..