Bawnorton / Neruina

A mod that prevents ticking related crashes from bricking worlds
MIT License
39 stars 3 forks source link

[1.20.1] Corail Tombstone ticking entity crash with Neruina (Random ticking entity crash. Perhaps related to a Receptable with a Familar?) #65

Closed Gbergz closed 6 months ago

Gbergz commented 6 months ago

Minecraft Version

1.20.1

Forge Version

47.2.17

Neruina Version

1.3.0

Corail Tombstone Version

8.6.5

What happened?

Server randomly crashed with "Ticking entity". Not entirely sure what triggered other than the ticking entity part and maybe because of a "Receptable" from Corail Tombstone.

Gametype

Dedicated Server

Occurence

Occurs rarely, not all the time.

Other relevant mods

Modpack is TNP Limitless 7: https://legacy.curseforge.com/minecraft/modpacks/tnp-limitless-7

Log Link

https://gist.githubusercontent.com/Gbergz/e886b799e2670299ff2b0826270bb2e6/raw/1b93c455a6b997ac446cf94b20e00e7fde29ba59/gistfile1.txt

    at ovh.corail.tombstone.helper.EntityHelper.loadPlayerData(EntityHelper.java:265) ~[tombstone-1.20.1-8.6.5.jar%231325!/:8.6.5] {re:mixin,re:classloading}
    at ovh.corail.tombstone.helper.EntityHelper.getOfflinePlayer(EntityHelper.java:273) ~[tombstone-1.20.1-8.6.5.jar%231325!/:8.6.5] {re:mixin,re:classloading}
    at ovh.corail.tombstone.item.ItemFamiliarReceptacle.captureSoul(ItemFamiliarReceptacle.java:221) ~[tombstone-1.20.1-8.6.5.jar%231325!/:8.6.5] {re:classloading}
    at ovh.corail.tombstone.event.EventHandler.onPreventDeath(EventHandler.java:411) ~[tombstone-1.20.1-8.6.5.jar%231325!/:8.6.5] {re:classloading}
    at ovh.corail.tombstone.event.__EventHandler_onPreventDeath_LivingDamageEvent.invoke(.dynamic) ~[tombstone-1.20.1-8.6.5.jar%231325!/:8.6.5] {re:classloading,pl:eventbus:B}

Tested without any Forge "alternatives" (Magma, Mohist, and so on)

Valid Launcher

Bawnorton commented 6 months ago

This is not an issue with neruina. Neruina cannot handle client-ticking-exceptions (ticking exceptions thrown on the player's render thread) which is why the error is re-thrown. 2.0.0 which was just released handles them better but this is an issue with Corail's tombstones.

Gbergz commented 6 months ago

Gotcha, reported here due to dev of Tombstone noting the stacktraces of Neruina. Then closing the issue over there.

Gbergz commented 6 months ago

https://github.com/Corail31/tombstone_lite/issues/221