search

BayAreaMetro / bayarea_urbansim

Bay Area Version of the UrbanSim Model
http://bayareametro.github.io/bayarea_urbansim
13 stars 11 forks source link

duplicated "def zone_forecast_inputs()" function #208

Closed yuqiww closed 4 years ago

yuqiww commented 4 years ago

def zone_forecast_inputs() seems to be duplicated, both in datasources.py and summaries.py. Do we need both?

fscottfoti commented 4 years ago

Seems like it should be removed from summaries. Probably harmless though.

On Fri, Aug 21, 2020 at 12:36 PM yuqi notifications@github.com wrote:

def zone_forecast_inputs() seems to be duplicated, both in datasources.py https://github.com/BayAreaMetro/bayarea_urbansim/blob/2869f5834d3e961694904c3fc4883cabf4fa7d9a/baus/datasources.py#L831 and summaries.py https://github.com/BayAreaMetro/bayarea_urbansim/blob/2869f5834d3e961694904c3fc4883cabf4fa7d9a/baus/summaries.py#L1773. Do we need both?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BayAreaMetro/bayarea_urbansim/issues/208, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOHNIE2ERWDL24QGIKCVFTSB3EEPANCNFSM4QHTH4DQ .

yuqiww commented 4 years ago

Since the additional function in summaries.py doesn't affect the run. Leave it as is.