baus.py currently checks for booleans for a number of steps. These will fail if the key is not defined in the run_setup.yaml file.
It may be cleaner to have the run_setup.yaml file be more minimal, with only relevant keys defined - and conversely in baus.py do a safe dict.get() check, with a False default.
This essentially means more default assumptions are moved to baus.py which may (or may not) be desirable.
Flagging this because errors are raised - the fix is either behavioral - enforce that any key mentioned in baus.py is defined in run_setup.yaml - or else, technical, using safe key getting in baus.py with appropriate defaults.
lmz
commented
9 months ago
baus.pycurrently checks for booleans for a number of steps. These will fail if the key is not defined in therun_setup.yamlfile.It may be cleaner to have the
run_setup.yamlfile be more minimal, with only relevant keys defined - and conversely inbaus.pydo a safe dict.get() check, with a False default.This essentially means more default assumptions are moved to
baus.pywhich may (or may not) be desirable.Flagging this because errors are raised - the fix is either behavioral - enforce that any key mentioned in
baus.pyis defined inrun_setup.yaml- or else, technical, using safe key getting inbaus.pywith appropriate defaults.https://github.com/BayAreaMetro/bayarea_urbansim/blob/d36fedca13617f01ee6ab6d277fa9797b25695ca/baus.py#L374