BayBreezy / strapi-plugin-email-designer-5

Design your own email templates directly from the Strapi admin panel and use the magic to send programmatically email from your controllers / services.
https://www.npmjs.com/package/strapi-plugin-email-designer-5
MIT License
7 stars 1 forks source link

Why not merge this back to the original? #10

Open boazpoolman opened 1 month ago

boazpoolman commented 1 month ago

Great work migrating this plugin to Strapi 5!

I wast just wondering why you didn't merge this back to the original repository? Seems rather confusing if there are multiple versions of the same plugin available.

BayBreezy commented 1 month ago

Hey @boazpoolman,

A few reasons:

I am open to this being merged into the main plugin. I would just need someone with a better understanding of how strapi works to help in doing so. I don't think I have deep enough knowledge to do that merge 🤣

boazpoolman commented 1 month ago

I might be able to help!

Just for my understanding, how did you start this new plugin? I guess it was a fork of the original?

BayBreezy commented 1 month ago

Started it with the new plugin sdk.

I honestly would not have touched plugins if the new sdk wasn't developed.

boazpoolman commented 1 month ago

And then you copied the contents from the original plugin?

BayBreezy commented 1 month ago

Pretty much.. doing a few tweaks here and there

begservice commented 1 month ago

Just to be honest, the old plugin is not really under support here, merging that into the "OG" plugin would not help anyone. This is a very nice tool to make strapi even better than it is. @boazpoolman is there a way to make it more of an strapi repository that somebody is moderating the merges into that? :)

begservice commented 1 month ago

i mean same as these plugin here: https://github.com/kucherenko/strapi-plugin-passwordless

Also fucking nice plugin, but really those plugins need to be more as features in Strapi would be awesome =)

boazpoolman commented 1 month ago

Yes, there are a lot of unmaintained plugins. That is just how Open Source works. When one maintainer steps down, another one stands up. And that's great!

My point is that the original repository of a project holds an invaluable amount of information:

It's amazing that people are willing to contribute to these plugins, so shout out to @BayBreezy for taking this task on! But if you feel like a plugin is unmaintained, please contact the current maintainer/author and talk to them about it. I'll bet most authors will be happy to make you a maintainer on the original repository to help them out. Or when they're looking to get out completely; move the to your name. That way we keep the Strapi community clean and neat.

BayBreezy commented 1 month ago

Yeah. I really wanted to use that passwordless plugin so bad in v4 but there so many issues that weren't getting any attention that i just left it alone. Found myself implementing the same passwordless logic manually :(.

I agree with your points @boazpoolman . Having one big repo where we can go and get all the info is great. As for the original email designer, I have not seen the maintainer do anything on that repo in a minute.

And like i said earlier in the convo, should a react noob (me) be in charge of a package that so many ppl are depending on? If this package blows up, it will force me to learn more React, which I am not a big fan of (Nuxt all the way 🚀). And I will have to reach out and bother the experts(@boazpoolman ) when i hit a road block.

When I put open source stuff out there, I always let ppl know that i am no expert LOLOL.

That is why I said I am open to this being merged into the original repo. Maybe we should go over there and ask the maintainer what they think about this merge?

boazpoolman commented 1 month ago

You don't have to be responsible for the package in order to contribute to it.

I think opening an issue on the original repo asking about this topic is great!

Let's see what the author thinks.

BayBreezy commented 1 month ago

Done @boazpoolman