search

BayBreezy / ui-thing

A set of components created with Radix-Vue. Inspired by shadcn/ui & shadcn-vue.
https://ui-thing.behonbaker.com
Other
314 stars 21 forks source link

Dialog close button offset #23

Closed BlueBazze closed 1 month ago

BlueBazze commented 1 month ago

image

From what i see, both the y position and height is off. In Ui/Dialog/Content.vue the usage of UiDialogClose has a class for top-2 which differs from shadcn-vue that has top-4. Is this a typo or by intention?

The height of the button. I believe it is because the nuxt icon renders as a <span> which causes line-height to kick in which is 24px. Adding the prop mode="svg" to the icon fixes this.

Here is a screenshot of the changes. image

Now the button is square and placed the same distance from the top and right. image

Im not gonna make a pr for this since the changes are so small, and the fact that i dont know if the top was intentionally set to 2.

BayBreezy commented 1 month ago

Hello! Ehhhhh... I mean... I can make the change... The good thing is that you own the code, so you can update it. Thanks for pointing it out tho. I honestly cant say it it was a mistake or done intentionally, I don't remember lol

BayBreezy commented 1 month ago

Done 🙂