Bayer-Group / paquo

PAthological QUpath Obsession - QuPath and Python conversations
GNU General Public License v3.0
104 stars 16 forks source link

Fix windows network share URIs in paquo #80

Closed ap-- closed 2 years ago

ap-- commented 2 years ago

Provides better URI handling by trying to normalise all file:// URIs to a supported 4-slash version.

Closes #65

See also:

With PR 1134 merged in QuPath all of this logic might be removed for QuPath-0.4.x support.

codecov-commenter commented 2 years ago

Codecov Report

Merging #80 (3662111) into main (7442f0d) will increase coverage by 0.00%. The diff coverage is 92.59%.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   89.16%   89.17%           
=======================================
  Files          27       27           
  Lines        3499     3547   +48     
=======================================
+ Hits         3120     3163   +43     
- Misses        379      384    +5     
Impacted Files Coverage Δ
paquo/jpype_backend.py 87.87% <ø> (ø)
paquo/projects.py 95.75% <ø> (ø)
paquo/images.py 97.86% <88.23%> (-1.12%) :arrow_down:
paquo/tests/conftest.py 100.00% <100.00%> (ø)
paquo/tests/test_projects.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ap-- commented 2 years ago

Merging now to start work on #81