search

BayesFlare / bayesflare

A python module to detect stellar flares using Bayesian model comparison
GNU General Public License v2.0
7 stars 4 forks source link

Model classes updated #1

Closed mattpitkin closed 9 years ago

mattpitkin commented 10 years ago

In the models branch there have been enhancements so that there is now a generic Model class. The individual signal models (e.g. the Flare model) now inherit the characteristics of the Model class.

In this update the methods within the classes that define the model function now only take in dictionaries of parameter values, with the dictionaries having to contain parameters required for the given model.

A new model class for a Step function is also included.

This has been tested and the plot_lightcurve script works correctly, but other tests should be performed (i.e. do the analysis scripts, and threshold/efficiency scripts still work). It should then be merged with the master branch and a new release be created.

mattpitkin commented 9 years ago

@transientlunatic - would you be happy with me merging this patch into master? It may create a fair few conflicts with your light curve generalisation branch.

transientlunatic commented 9 years ago

Looks fine to me; I'll resolve the merge conflicts whenever the lightcurve work's ready to fully incorporate into master. :+1: