search

BayesianLogic / blog

The BLOG programming language
http://bayesianlogic.github.io/
BSD 4-Clause "Original" or "Old" License
98 stars 31 forks source link

Refactoring #300

Open chrisgioia64 opened 9 years ago

chrisgioia64 commented 9 years ago

This issue will deal with:

  1. Fixing Java Warnings (e.g. No generic type for List)
  2. Removing obsolete files.

These issues will be addressed in the branch warnings

lileicc commented 9 years ago

@chrisgioia64 Great!

chrisgioia64 commented 9 years ago

The following source files have no explicit references to that class from somewhere outside that class. More concretely, for NumberEvidence, running the command below produces 0

grep -r NumberEvidence blog/src/main/java | grep -v NumberEvidence | wc -l

@lileicc @cberzan I excluded files in distrib package because there is some designated way where the BLOG engine searches for all files in the distrib package. I included some sampling and inference classes since they have no references in the code but are referenced on the command line and don't know which ones are obsolete.

If you can mark the files below that can be safely removed.

To delete:

To keep:

cberzan commented 9 years ago

@chrisgioia64 I marked the files to be deleted above. Also I think you can remove these:

Thanks for doing this cleanup.

lileicc commented 9 years ago

@chrisgioia64

You may try to use eclipse to find reference for a specific class.

Do not remove anything under engine and sample, since they can be used from commandline (-s or -e).

I agree that many of the files under common can be removed, or they should be.

Lei

On Wed, Aug 20, 2014 at 3:09 PM, cberzan notifications@github.com wrote:

@chrisgioia64 https://github.com/chrisgioia64 I marked the files to be deleted above. Also I think you can remove these:

  • common/ImplicitVector.java
  • test/blog/DistanceTest.java
  • common/IndexedTreeSet.java

— Reply to this email directly or view it on GitHub https://github.com/BayesianLogic/blog/issues/300#issuecomment-52852029.

chrisgioia64 commented 9 years ago

The following files are not reachable from src/main/java/blog/Main.java. Should I keep these?

chrisgioia64 commented 9 years ago

@lileicc inside Absyn.java, why is printTree deprecated

lileicc commented 9 years ago

DBLOGUtil should not be deleted. I will check all these files and remove them if necessary.

printTree is replaced by prettyPrinter

On Wed, Aug 27, 2014 at 10:54 AM, Christopher Gioia < notifications@github.com> wrote:

@lileicc https://github.com/lileicc inside Absyn.java, why is printTree deprecated

— Reply to this email directly or view it on GitHub https://github.com/BayesianLogic/blog/issues/300#issuecomment-53613395.

chrisgioia64 commented 9 years ago

@lileicc Does issue #304 take care of the changes in the warnings branch?