search

BayesianLogic / blog

The BLOG programming language
http://bayesianlogic.github.io/
BSD 4-Clause "Original" or "Old" License
98 stars 31 forks source link

solving PF memory growth issue #324

Closed lileicc closed 10 years ago

lileicc commented 10 years ago

disable the use of CBN in DefaultPossibleWorld, which is used in PF and LWSampler. But LWSampler doesnot need CBN information.

@jxwuyi @datang1992

datang1992 commented 10 years ago

@lileicc LGTM with minor changes. But it will have several conflicts with the file changes in the branch #305 on the CBN part the partial world part.

lileicc commented 10 years ago

@datang1992 Note that the changes will only affect those using DefaultPossibleWorld, won't affect the PartialWorldDiff. Therefore, only LWSampler and ParticleFilter will be affected.

datang1992 commented 10 years ago

@lileicc What I mean is that I changed something in the partial world file in the #305. Therefore there should be some conflicts.

lileicc commented 10 years ago

@datang1992 @jxwuyi ready to review again. Previously the PF might still accumulate memory, due the the variables in dirtyVars in AbstractPartialWorld will be accumulated if there is not evidence.

lileicc commented 10 years ago

@datang1992 As long as the underlying CBN is dynamical Bayesian network, it should be fine. For open universe models, I donot think we support PF anyway.

datang1992 commented 10 years ago

OK. If we don't allow PF for OU models, then it LGTM.

jxwuyi commented 10 years ago

Overall LGTM