search

Baystation12 / Baystation12

Baystation's flavor of Space Station 13
https://baystation.xyz
GNU Affero General Public License v3.0
407 stars 1.62k forks source link

Heat Exchange pipes are deleted when wrenched down. #10211

Closed FenodyreeAv closed 9 years ago

FenodyreeAv commented 9 years ago

Brief description of the issue: When wrenching down H/E, H/E Bent or Junction pipes, they simply vanish instead of being installed. What you expected to happen: H/E pipes to be connected by adaptor to other pipes and function. What actually happened: The pipes were deleted from the game. Steps to reproduce: Attempt to wrench down an H/E pipe. Additional info: he bug 2

he bug 1

Dennok commented 9 years ago

This is some bigger bug. If you trying wrench pipe in loc where it cant inicialize it del need always wretch pipe to another pipe

scrnshot1

ghost commented 9 years ago

To clarify, the bug is that H/E pipes allow you to wrench them in an invalid configuration, not that they disappear when wrenched this way.

mwerezak commented 9 years ago

No, that sounds more like a thinly veiled proposal for a fix.

From the player's perspective anyway, the bug seems to be largely what FenodyreeAv described.

ghost commented 9 years ago

Let me rephrase that: The reason most pipes do not experience this bug, is due to the fact that they can not be wrenched in an invalid configuration. Therefore, for consistencies sake, this is the most reasonable fix.

Happy?

mwerezak commented 9 years ago

Sorry if that came across harshly.

FenodyreeAv commented 9 years ago

I tested this a little more, and It's not that the pipes are letting themselves be wrenched down in a place they can't go. I unwrenched the engine cooling pipes, and immediately tried to put them back and they were deleted. image image

Dennok commented 9 years ago

Check version of dev freeze. On last all work. all pipes can be wrenched an invalid configuration and pipe qdel hemself after bad inicializacion. I think if change qdel in inicializacion to Destroy (unwrench) all be norm.

mwerezak commented 9 years ago

This bug only occurs for H/E piping and not regular piping right? After a cursory look at the pipe construction/initialization code I can't see any significant difference between the two.

FenodyreeAv commented 9 years ago

Yup, normal piping seems to work as expected.

GinjaNinja32 commented 9 years ago

normal pipes appear to qdel() themselves when wrenched in invalid positions, possibly related.

ghost commented 9 years ago

This effects all pipes.