Baystation12 / Baystation12

Baystation's flavor of Space Station 13
https://baystation.xyz
GNU Affero General Public License v3.0
405 stars 1.62k forks source link

EOD suit + Ear protection + Sunglasses do effectively nothing against flashbangs. #6041

Closed ghost closed 8 years ago

ghost commented 10 years ago

Title says it. After toying on the test server, this was discovered to allow me to be one tile closer to an active flash-bang when compared to me being equipped with nothing.

Nothing big but still. EOD suit.

Glloyd commented 10 years ago

So it still knocked you down and temporarily blinded/deafened you with all that on?

mwerezak commented 10 years ago

Seems that flashbang does not check armour at all.

mwerezak commented 10 years ago

So, there seems to be two options with this. I could make the flashbang effective blast radii depend on your explosion armour protection, or I could make EOD helmets come with built-in ear_safety.

Any ideas on which approach would be better?

Walter0o commented 10 years ago

ear_safety should be checked against an item flag TBH instead of hard type checks, but i guess another typecheck around line 43 would do too.

ghost commented 10 years ago

yes and yes @Glloyd. Wearing nothing would have been virtually the same as me tanked to all hell.

@mwerezak - Would the ear_safety addition act the same way as earpro? Would it muffle everything, including radios?

Walter0o commented 10 years ago

@zaredman ear_safety is a specific thing to flashbang detonation, radios and other sounds are currently not muffled by items, only ear damage AFAIK. EDIT: well technically earmuffs do block hearing by the human life check looking for earmuffs and applying the deaf flag to the wearer, which is done via yet another hard typecheck, but that is all mob-side.

GinjaNinja32 commented 9 years ago

AFAICT, the sunglasses do prevent the flash overlay, and the earmuffs do prevent most of the knockdown.