Closed ByYogi closed 7 months ago
Thanks for posting your issue, but I'm not sure what I can do about this. I try to make it as user-friendly as possible, so I'm sorry to hear you couldn't find this option right away. Where did you expect this option to be, where were you looking for it?
The colors can be changed in the settings dialog, imho that is the logical place. I could make the button a bit bigger or add the colored "Aa" icon to it, so that the button stands out a bit more on the dialog, if that's what you mean?
I have updated the documentation, and moved the syntax highlighting colors to the top. Syntax highlighting is an important feature and shouldn't be all the way at the bottom of the documentation.
Also, at first time startup the plugin would randomly select a colorset. This was done with the idea to "distribute" the 4 color sets among the users, so in 50% of cases the default color highlighting was "foreground color".
However, after having worked with the plugin some time now, I think Background colors
and Darkmode Neon
are generally the best default options. With the other two (Forground Colors
and Darkmode Pastel
) there is far less contrast and the columns are less clearly visible. Plus, if the user does want "Forground Colors" or "Pastel" they can still change it in the settings anyway.
I've changed this so that "Foreground colors" will not be a default anymore, this will be available in the next release.
Thanks for posting your issue, but I'm not sure what I can do about this. I try to make it as user-friendly as possible, so I'm sorry to hear you couldn't find this option right away. Where did you expect this option to be, where were you looking for it?
The colors can be changed in the settings dialog, imho that is the logical place. I could make the button a bit bigger or add the colored "Aa" icon to it, so that the button stands out a bit more on the dialog, if that's what you mean?
Thanks for noticing.
I prefer to look for the configuration I want in the following places
Or you can change the description of the button to "Highlight". It's easier to understand the meaning than "Color".
I think the biggest problem is, that this button is not reminiscent of a button with options. It's mistaken for a click function, like the ok and cancel buttons in the bottom right corner.
I think the simplest change would be to change the description info.
Highlight ▾
I've updated the color button using this example. I also tried adding the color icon to the button (on the right), but I think it looks better without the icon (on the left).
@ByYogi Are you able to download the "beta" build DLL to check if the button displays correctly also on your system? It will be in the next release
On my win10 system it doesn't look displaying correctly
Here's a dll I tried to make from the source code.
https://github.com/BdR76/CSVLint/assets/111735598/27fd28a7-1e25-46aa-b1ca-a9a1faa0d6ef
Thanks for posting the screenshots, this was really helpful. It looks like the Highlighting-button was not wide enough. It was 100px and I've updated it to be 128px, also see the "beta" build DLL.
I saw that you changed the button to also display the icon, and show the selected icon as well. However, I don't think this could work generally, because when you've just started the Settings dialog and haven't selected or changed anything, then the plugin cannot know which of the 4 items was selected previously.
This is due to the fact that only the 12 colors are stored, and the user can change these colors to anything they like in the preferences dialog. In other words, the selected menu item (1 through 4) is not stored anywhere.
@BdR76 Looks good
Fixed in latest release
The default color highlighting is foreground color. I'd like to change it to background color, but I can't find a way to do it. I searched for about 3 hours, fanally I found what I was looking for in this document
So, I think putting the button in this position is inhuman.