search

BdR76 / RandomValuesNPP

Generate random values plug-in for Notepad++. Use this plugin to generate passwords, guids or random datasets in CSV, JSON, XML and SQL formats. Use the fake test data for performance and QA testing to improve software quality in application development, reports, database modeling, webdev etc.
15 stars 4 forks source link

Fix 9 rows limit bug in Generate form #8

Closed htcfreek closed 1 year ago

htcfreek commented 1 year ago

The generate form ignores the 10th rows on saving the settings and generating the random values. The reason are two bugs in the file RandomValuesNppPlugin/Forms/GenerateForm.cs where the for loops only count till 9 instead of 10.

This PR fixes the bug(s).

Fixes issue: #7

⚠ Note: I didn't compile an test the code!!

htcfreek commented 1 year ago

PR isn't ready for review. For a good user experience I will add a che k to prevent users from adding more the 10 rows.

htcfreek commented 1 year ago

@BdR76 Now the PR is ready for review.

BdR76 commented 1 year ago

Thanks for the PR, actually the reason the nr of user items is limited to 10 in the first place, is because I couldn't figure out how to set a stringlist as one settings item in the settings .ini file.

I'll look into how to use the stringlist in the PropertyGrid, it can be done using a System.ComponentModel.Editor. That way there won't be an arbitrary limit on the nr of items to begin with.

htcfreek commented 1 year ago

@BdR76 Can you please provide a hotfix release? I like to create a updated deployment package of np++ for our company. It would be great if I can add a fixed version of the plugin.

BdR76 commented 1 year ago

I've build the DLLs for an intermediate version v0.2.2β with the current fixes, see the dll in Release and Release-x64 folders.

https://github.com/BdR76/RandomValuesNPP/tree/main/RandomValuesNppPlugin/bin

I'm still looking how to add a stringlist as part of the settings dialog and ini file. If that works I'll create a new release

cheers Bas