search

BeIntrepid / Trello-Card-Dependencies

Chrome extension that helps you to map dependencies between your cards in Trello
https://chrome.google.com/webstore/detail/trello-card-dependencies/ddhnhdoghhfoeceiohphmjkcemlkkock?hl=en
GNU General Public License v2.0
25 stars 12 forks source link

General Cleanup + Some Styles + Cool Loading Spinner #1

Closed oneezy closed 9 years ago

oneezy commented 9 years ago

Hey Alex, Did a lot of clean up/ restructuring/ simplifying. Started by extracting the inline/inpage styles from the html/js and linked into an external stylsheet (css/stylesheet.css). Also re-did the leftside navigation for better style control, along with a few "soft" style tweaks. For the color choices on the cards, I'm using the Material Design visual guidelines spec from Google..it seems to fit in nicely with Trello's colors. Didn't touch any of the js logic or tackle any bugs. Just wanted to take it easy on this first go round.

There were a few more things I wanted to get in before I sent this initial pull request. There's a "FOUJ" (Flash Of Uninitialized Javascript) that shows in the navigation when clicking the show/hide dependencies. It can be fixed by using inline styles there or using a delayed css transition/animation. Also, the SVG spinner is acting up a bit (I believe it's from it not being pre-loaded and the animation can't keep up w/ the rest).

Everything seems to be looking good though.

alexanderpreston commented 9 years ago

Nice, I merged the pull request and it looks pretty good. Just a couple of bugs to fix on the Development board and I'll release v1.7!

alexanderpreston commented 9 years ago

https://trello.com/b/o2OGA28L/development

oneezy commented 9 years ago

niCe! I'll fix a few more things up and make another push this weekend

alexanderpreston commented 9 years ago

Hi Justin, How's it going? Sorry for going dark, I had a few things with the business to attend to after getting back from holiday. Did you have any luck with those bugs?

alexanderpreston commented 9 years ago

Hi @oneezy - are you on Skype?

oneezy commented 9 years ago

Hey Alex,Sorry been out of commission lately. Been out of town and not at a computer for awhile. i have a Skype but i use Google Hangouts mainly now. I'll reach back out to you soon.

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message -------- From: Alexander Preston notifications@github.com Date: 06/18/2015 6:17 AM (GMT-06:00) To: BeIntrepid/Trello-Card-Dependencies Trello-Card-Dependencies@noreply.github.com Cc: oneezy mrrioku@yahoo.com Subject: Re: [Trello-Card-Dependencies] General Cleanup + Some Styles + Cool Loading Spinner (#1)

Hi @oneezy - are you on Skype?

— Reply to this email directly or view it on GitHub.