Extension fails if a member of a relationship is deleted

[liambrownweb]

Deleting a card with a dependent causes the dependency graph to fail to display; the script errors out when showing the dependencies screen, and nothing works. The problem dependency then has to be deleted from the comments section of the remaining card.

To reproduce,

1. Create two cards in a Trello board.
2. Show dependencies.
3. Add a dependency between the cards.
4. Hide dependencies.
5. Delete the parent card.
6. Show dependencies again; it should now fail.

I suggest the following elements to remedy the issue:

• Dependency validation at run-time. If it's possible to trigger validation on board changes, do it then and limit checks to affected cards and hierarchies.
• Error handling. If an exception arises, make sure it doesn't cripple the graph.
• Error display. A visual indicator on the affected cards, a broken or otherwise wonky connector, and probably a sidebar element with a list of problems to resolve.

I see the activity on this repo has been zero for a while, so I'm guessing you guys are busy. I'm happy to write this stuff myself and submit a PR if you still want to maintain the extension in the Chrome store. If you want to review those items and write a spec, I'll put in the coding time and get you something you can release. Let me know.

[alexanderpreston]

Hi Liam,

Thanks for your message. You are very right in that we’re busy. Since we made the switch from Trello to JIRA for project management we haven’t been able to give the plug in any love.

If you are willing to fix the issues that you have discovered with it, I’d be happy to perform some QA on it and deploy an update to the store.

Alex.

Alexander Preston
Managing Director Intrepid e: alexander@beintrepid.co.uk t: +442037276351 m: +447414829862 One Euston Square 40 Melton Street London NW1 2FD +44 203 727 6350 We believe technology should provide us with more of our most precious resource, time. Information Technology | Software Development | Process Engineering Disclaimer: This message contains confidential information for the intended recipient only. If you are not the intended recipient you should not disseminate, distribute or copy this e-mail. Please notify immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. Intrepid Ltd therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission. If verification is required please request a hard-copy version. Intrepid Ltd is a company registered in England and Wales under number 07480378. Registered office: 28 Newell Road, Hemel Hempstead, Hertfordshire, HP3 9PB, UK. From: Liam Brown [mailto:notifications@github.com] Sent: 08 May 2017 18:38 To: BeIntrepid/Trello-Card-Dependencies Trello-Card-Dependencies@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [BeIntrepid/Trello-Card-Dependencies] Extension fails if a member of a relationship is deleted (#6)

Deleting a card with a dependent causes the dependency graph to fail to display; the script errors out when showing the dependencies screen, and nothing works. The problem dependency then has to be deleted from the comments section of the remaining card.

To reproduce,

1. Create two cards in a Trello board.
2. Show dependencies.
3. Add a dependency between the cards.
4. Hide dependencies.
5. Delete the parent card.
6. Show dependencies again; it should now fail.

I suggest the following elements to remedy the issue:

• Dependency validation at run-time. If it's possible to trigger validation on board changes, do it then and limit checks to affected cards and hierarchies.
• Error handling. If an exception arises, make sure it doesn't cripple the graph.
• Error display. A visual indicator on the affected cards, a broken or otherwise wonky connector, and probably a sidebar element with a list of problems to resolve.

I see the activity on this repo has been zero for a while, so I'm guessing you guys are busy. I'm happy to write this stuff myself and submit a PR if you still want to maintain the extension in the Chrome store. If you want to review those items and write a spec, I'll put in the coding time and get you something you can release. Let me know.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/BeIntrepid/Trello-Card-Dependencies/issues/6, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABurDnAsoHw-A9AwkZxMtFPow2TOl-Ltks5r31LngaJpZM4NUQwF.