Most are just coding convention things, take it or leave it ;)
I would fix these:
[FixInsight Warning] FLRE.pas(13913): W502 Empty FINALLY block
[FixInsight Warning] FLRE.pas(17211): W509 Unreachable code
And Check this:
[FixInsight Warning] FLRE.pas(9147): W503 Assignment right hand side is equal to its left hand side
All reported issues below (With settings I selected):
[FixInsight Convention] FLRE.pas(525): C107 Class field name 'PageSize' should start with 'F'
[FixInsight Convention] FLRE.pas(526): C107 Class field name 'Alignment' should start with 'F'
[FixInsight Convention] FLRE.pas(652): C107 Class field name 'RealSize' should start with 'F'
[FixInsight Convention] FLRE.pas(653): C107 Class field name 'LogSize' should start with 'F'
[FixInsight Convention] FLRE.pas(654): C107 Class field name 'Size' should start with 'F'
[FixInsight Convention] FLRE.pas(655): C107 Class field name 'Entities' should start with 'F'
[FixInsight Convention] FLRE.pas(656): C107 Class field name 'EntityToCellIndex' should start with 'F'
[FixInsight Convention] FLRE.pas(657): C107 Class field name 'CellToEntityIndex' should start with 'F'
[FixInsight Convention] FLRE.pas(720): C107 Class field name 'List' should start with 'F'
[FixInsight Convention] FLRE.pas(721): C107 Class field name 'CountItems' should start with 'F'
[FixInsight Convention] FLRE.pas(722): C107 Class field name 'Allocated' should start with 'F'
[FixInsight Convention] FLRE.pas(723): C107 Class field name 'IsSorted' should start with 'F'
[FixInsight Convention] FLRE.pas(1000): C107 Class field name 'AllNext' should start with 'F'
[FixInsight Convention] FLRE.pas(1032): C107 Class field name 'RegularExpression' should start with 'F'
[FixInsight Convention] FLRE.pas(1034): C107 Class field name 'OriginalRegularExpression' should start with 'F'
[FixInsight Convention] FLRE.pas(1038): C107 Class field name 'InternalFlags' should start with 'F'
[FixInsight Convention] FLRE.pas(1040): C107 Class field name 'AnchoredRootNode' should start with 'F'
[FixInsight Convention] FLRE.pas(1042): C107 Class field name 'UnanchoredRootNode' should start with 'F'
[FixInsight Convention] FLRE.pas(1044): C107 Class field name 'RegularExpressionHasCharClasses' should start with 'F'
[FixInsight Convention] FLRE.pas(1046): C107 Class field name 'Nodes' should start with 'F'
[FixInsight Convention] FLRE.pas(1048): C107 Class field name 'CountCaptures' should start with 'F'
[FixInsight Convention] FLRE.pas(1050): C107 Class field name 'CountInternalCaptures' should start with 'F'
[FixInsight Convention] FLRE.pas(1052): C107 Class field name 'CountSubMatches' should start with 'F'
[FixInsight Convention] FLRE.pas(1054): C107 Class field name 'CountMultiSubMatches' should start with 'F'
[FixInsight Convention] FLRE.pas(1056): C107 Class field name 'CapturesToSubMatchesMap' should start with 'F'
[FixInsight Convention] FLRE.pas(1059): C107 Class field name 'CountForwardInstructions' should start with 'F'
[FixInsight Convention] FLRE.pas(1061): C107 Class field name 'BackwardInstructions' should start with 'F'
[FixInsight Convention] FLRE.pas(1062): C107 Class field name 'CountBackwardInstructions' should start with 'F'
[FixInsight Convention] FLRE.pas(1064): C107 Class field name 'AnchoredStartInstruction' should start with 'F'
[FixInsight Convention] FLRE.pas(1065): C107 Class field name 'UnanchoredStartInstruction' should start with 'F'
[FixInsight Convention] FLRE.pas(1066): C107 Class field name 'ReversedStartInstruction' should start with 'F'
[FixInsight Convention] FLRE.pas(1068): C107 Class field name 'CharClasses' should start with 'F'
[FixInsight Convention] FLRE.pas(1069): C107 Class field name 'CountCharClasses' should start with 'F'
[FixInsight Convention] FLRE.pas(1071): C107 Class field name 'CharClassHashMap' should start with 'F'
[FixInsight Convention] FLRE.pas(1073): C107 Class field name 'LookAssertionStrings' should start with 'F'
[FixInsight Convention] FLRE.pas(1074): C107 Class field name 'CountLookAssertionStrings' should start with 'F'
[FixInsight Convention] FLRE.pas(1087): C107 Class field name 'CountFirstPrefixCharRanges' should start with 'F'
[FixInsight Convention] FLRE.pas(1089): C107 Class field name 'CountPrefixCharClasses' should start with 'F'
[FixInsight Convention] FLRE.pas(1090): C107 Class field name 'AveragePrefixCharClassesVariance' should start with 'F'
[FixInsight Convention] FLRE.pas(1091): C107 Class field name 'PrefixPatternBitMasks' should start with 'F'
[FixInsight Convention] FLRE.pas(1093): C107 Class field name 'ByteMap' should start with 'F'
[FixInsight Convention] FLRE.pas(1094): C107 Class field name 'UnByteMap' should start with 'F'
[FixInsight Convention] FLRE.pas(1095): C107 Class field name 'ByteCharSetMap' should start with 'F'
[FixInsight Convention] FLRE.pas(1096): C107 Class field name 'ByteMapCount' should start with 'F'
[FixInsight Convention] FLRE.pas(1098): C107 Class field name 'OnePassNFANodes' should start with 'F'
[FixInsight Convention] FLRE.pas(1099): C107 Class field name 'OnePassNFANodesCount' should start with 'F'
[FixInsight Convention] FLRE.pas(1100): C107 Class field name 'OnePassNFAStart' should start with 'F'
[FixInsight Convention] FLRE.pas(1101): C107 Class field name 'OnePassNFAStateSize' should start with 'F'
[FixInsight Convention] FLRE.pas(1102): C107 Class field name 'OnePassNFACharClassActions' should start with 'F'
[FixInsight Convention] FLRE.pas(1104): C107 Class field name 'NamedGroupStringList' should start with 'F'
[FixInsight Convention] FLRE.pas(1105): C107 Class field name 'NamedGroupStringIntegerPairHashMap' should start with 'F'
[FixInsight Convention] FLRE.pas(1107): C107 Class field name 'ParallelLock' should start with 'F'
[FixInsight Convention] FLRE.pas(1109): C107 Class field name 'ThreadLocalStorageInstanceManagerParallelLock' should start with 'F'
[FixInsight Convention] FLRE.pas(1111): C107 Class field name 'ThreadLocalStorageInstances' should start with 'F'
[FixInsight Convention] FLRE.pas(1114): C107 Class field name 'RangeLow' should start with 'F'
[FixInsight Convention] FLRE.pas(1115): C107 Class field name 'RangeHigh' should start with 'F'
[FixInsight Convention] FLRE.pas(1117): C107 Class field name 'PrefilterRootNode' should start with 'F'
[FixInsight Convention] FLRE.pas(1271): C107 Class field name 'ParallelLock' should start with 'F'
[FixInsight Convention] FLRE.pas(1272): C107 Class field name 'List' should start with 'F'
[FixInsight Convention] FLRE.pas(1273): C107 Class field name 'HashMap' should start with 'F'
[FixInsight Convention] FLRE.pas(667): C110 Getter or setter name is different from property declaration
[FixInsight Convention] FLRE.pas(746): C110 Getter or setter name is different from property declaration
[FixInsight Convention] FLRE.pas(831): C110 Getter or setter name is different from property declaration
[FixInsight Convention] FLRE.pas(831): C110 Getter or setter name is different from property declaration
[FixInsight Warning] FLRE.pas(13913): W502 Empty FINALLY block
[FixInsight Warning] FLRE.pas(9147): W503 Assignment right hand side is equal to its left hand side
[FixInsight Warning] FLRE.pas(17211): W509 Unreachable code
[FixInsight Warning] FLRE.pas(12510): W517 Variable 'CountInstructions' hides a class field, method or property
[FixInsight Warning] FLRE.pas(17465): W517 Variable 'Flags' hides a class field, method or property
[FixInsight Warning] FLRE.pas(19018): W517 Variable 'Nodes' hides a class field, method or property
[FixInsight Warning] FLRE.pas(14414): W528 Variable 'Counter' not used in FOR-loop
[FixInsight Warning] FLRE.pas(14432): W528 Variable 'Counter' not used in FOR-loop
[FixInsight Warning] FLRE.pas(14441): W528 Variable 'Counter' not used in FOR-loop
[FixInsight Warning] FLRE.pas(14447): W528 Variable 'Counter' not used in FOR-loop
[FixInsight Warning] FLRE.pas(1634): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(1696): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(1697): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(1704): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(1705): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(5757): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(5774): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(5901): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(5922): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6061): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6085): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6236): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6263): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6426): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6456): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6631): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6664): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6851): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(6887): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(7088): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] FLRE.pas(7127): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Optimization] FLRE.pas(2988): O804 Method parameter 'Fallback' is declared but never used
[FixInsight Optimization] FLRE.pas(22407): O804 Method parameter 'Error' is declared but never used
[FixInsight Warning] pucu.pas(42397): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] pucu.pas(42640): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Warning] pucu.pas(42822): W541 Casting from Integer to Pointer type (or vice versa)
[FixInsight Optimization] pucu.pas(41047): O804 Method parameter 'Fallback' is declared but never used
Most are just coding convention things, take it or leave it ;)
I would fix these: [FixInsight Warning] FLRE.pas(13913): W502 Empty FINALLY block [FixInsight Warning] FLRE.pas(17211): W509 Unreachable code
And Check this: [FixInsight Warning] FLRE.pas(9147): W503 Assignment right hand side is equal to its left hand side
All reported issues below (With settings I selected): [FixInsight Convention] FLRE.pas(525): C107 Class field name 'PageSize' should start with 'F' [FixInsight Convention] FLRE.pas(526): C107 Class field name 'Alignment' should start with 'F' [FixInsight Convention] FLRE.pas(652): C107 Class field name 'RealSize' should start with 'F' [FixInsight Convention] FLRE.pas(653): C107 Class field name 'LogSize' should start with 'F' [FixInsight Convention] FLRE.pas(654): C107 Class field name 'Size' should start with 'F' [FixInsight Convention] FLRE.pas(655): C107 Class field name 'Entities' should start with 'F' [FixInsight Convention] FLRE.pas(656): C107 Class field name 'EntityToCellIndex' should start with 'F' [FixInsight Convention] FLRE.pas(657): C107 Class field name 'CellToEntityIndex' should start with 'F' [FixInsight Convention] FLRE.pas(720): C107 Class field name 'List' should start with 'F' [FixInsight Convention] FLRE.pas(721): C107 Class field name 'CountItems' should start with 'F' [FixInsight Convention] FLRE.pas(722): C107 Class field name 'Allocated' should start with 'F' [FixInsight Convention] FLRE.pas(723): C107 Class field name 'IsSorted' should start with 'F' [FixInsight Convention] FLRE.pas(1000): C107 Class field name 'AllNext' should start with 'F' [FixInsight Convention] FLRE.pas(1032): C107 Class field name 'RegularExpression' should start with 'F' [FixInsight Convention] FLRE.pas(1034): C107 Class field name 'OriginalRegularExpression' should start with 'F' [FixInsight Convention] FLRE.pas(1038): C107 Class field name 'InternalFlags' should start with 'F' [FixInsight Convention] FLRE.pas(1040): C107 Class field name 'AnchoredRootNode' should start with 'F' [FixInsight Convention] FLRE.pas(1042): C107 Class field name 'UnanchoredRootNode' should start with 'F' [FixInsight Convention] FLRE.pas(1044): C107 Class field name 'RegularExpressionHasCharClasses' should start with 'F' [FixInsight Convention] FLRE.pas(1046): C107 Class field name 'Nodes' should start with 'F' [FixInsight Convention] FLRE.pas(1048): C107 Class field name 'CountCaptures' should start with 'F' [FixInsight Convention] FLRE.pas(1050): C107 Class field name 'CountInternalCaptures' should start with 'F' [FixInsight Convention] FLRE.pas(1052): C107 Class field name 'CountSubMatches' should start with 'F' [FixInsight Convention] FLRE.pas(1054): C107 Class field name 'CountMultiSubMatches' should start with 'F' [FixInsight Convention] FLRE.pas(1056): C107 Class field name 'CapturesToSubMatchesMap' should start with 'F' [FixInsight Convention] FLRE.pas(1059): C107 Class field name 'CountForwardInstructions' should start with 'F' [FixInsight Convention] FLRE.pas(1061): C107 Class field name 'BackwardInstructions' should start with 'F' [FixInsight Convention] FLRE.pas(1062): C107 Class field name 'CountBackwardInstructions' should start with 'F' [FixInsight Convention] FLRE.pas(1064): C107 Class field name 'AnchoredStartInstruction' should start with 'F' [FixInsight Convention] FLRE.pas(1065): C107 Class field name 'UnanchoredStartInstruction' should start with 'F' [FixInsight Convention] FLRE.pas(1066): C107 Class field name 'ReversedStartInstruction' should start with 'F' [FixInsight Convention] FLRE.pas(1068): C107 Class field name 'CharClasses' should start with 'F' [FixInsight Convention] FLRE.pas(1069): C107 Class field name 'CountCharClasses' should start with 'F' [FixInsight Convention] FLRE.pas(1071): C107 Class field name 'CharClassHashMap' should start with 'F' [FixInsight Convention] FLRE.pas(1073): C107 Class field name 'LookAssertionStrings' should start with 'F' [FixInsight Convention] FLRE.pas(1074): C107 Class field name 'CountLookAssertionStrings' should start with 'F' [FixInsight Convention] FLRE.pas(1087): C107 Class field name 'CountFirstPrefixCharRanges' should start with 'F' [FixInsight Convention] FLRE.pas(1089): C107 Class field name 'CountPrefixCharClasses' should start with 'F' [FixInsight Convention] FLRE.pas(1090): C107 Class field name 'AveragePrefixCharClassesVariance' should start with 'F' [FixInsight Convention] FLRE.pas(1091): C107 Class field name 'PrefixPatternBitMasks' should start with 'F' [FixInsight Convention] FLRE.pas(1093): C107 Class field name 'ByteMap' should start with 'F' [FixInsight Convention] FLRE.pas(1094): C107 Class field name 'UnByteMap' should start with 'F' [FixInsight Convention] FLRE.pas(1095): C107 Class field name 'ByteCharSetMap' should start with 'F' [FixInsight Convention] FLRE.pas(1096): C107 Class field name 'ByteMapCount' should start with 'F' [FixInsight Convention] FLRE.pas(1098): C107 Class field name 'OnePassNFANodes' should start with 'F' [FixInsight Convention] FLRE.pas(1099): C107 Class field name 'OnePassNFANodesCount' should start with 'F' [FixInsight Convention] FLRE.pas(1100): C107 Class field name 'OnePassNFAStart' should start with 'F' [FixInsight Convention] FLRE.pas(1101): C107 Class field name 'OnePassNFAStateSize' should start with 'F' [FixInsight Convention] FLRE.pas(1102): C107 Class field name 'OnePassNFACharClassActions' should start with 'F' [FixInsight Convention] FLRE.pas(1104): C107 Class field name 'NamedGroupStringList' should start with 'F' [FixInsight Convention] FLRE.pas(1105): C107 Class field name 'NamedGroupStringIntegerPairHashMap' should start with 'F' [FixInsight Convention] FLRE.pas(1107): C107 Class field name 'ParallelLock' should start with 'F' [FixInsight Convention] FLRE.pas(1109): C107 Class field name 'ThreadLocalStorageInstanceManagerParallelLock' should start with 'F' [FixInsight Convention] FLRE.pas(1111): C107 Class field name 'ThreadLocalStorageInstances' should start with 'F' [FixInsight Convention] FLRE.pas(1114): C107 Class field name 'RangeLow' should start with 'F' [FixInsight Convention] FLRE.pas(1115): C107 Class field name 'RangeHigh' should start with 'F' [FixInsight Convention] FLRE.pas(1117): C107 Class field name 'PrefilterRootNode' should start with 'F' [FixInsight Convention] FLRE.pas(1271): C107 Class field name 'ParallelLock' should start with 'F' [FixInsight Convention] FLRE.pas(1272): C107 Class field name 'List' should start with 'F' [FixInsight Convention] FLRE.pas(1273): C107 Class field name 'HashMap' should start with 'F' [FixInsight Convention] FLRE.pas(667): C110 Getter or setter name is different from property declaration [FixInsight Convention] FLRE.pas(746): C110 Getter or setter name is different from property declaration [FixInsight Convention] FLRE.pas(831): C110 Getter or setter name is different from property declaration [FixInsight Convention] FLRE.pas(831): C110 Getter or setter name is different from property declaration [FixInsight Warning] FLRE.pas(13913): W502 Empty FINALLY block [FixInsight Warning] FLRE.pas(9147): W503 Assignment right hand side is equal to its left hand side [FixInsight Warning] FLRE.pas(17211): W509 Unreachable code [FixInsight Warning] FLRE.pas(12510): W517 Variable 'CountInstructions' hides a class field, method or property [FixInsight Warning] FLRE.pas(17465): W517 Variable 'Flags' hides a class field, method or property [FixInsight Warning] FLRE.pas(19018): W517 Variable 'Nodes' hides a class field, method or property [FixInsight Warning] FLRE.pas(14414): W528 Variable 'Counter' not used in FOR-loop [FixInsight Warning] FLRE.pas(14432): W528 Variable 'Counter' not used in FOR-loop [FixInsight Warning] FLRE.pas(14441): W528 Variable 'Counter' not used in FOR-loop [FixInsight Warning] FLRE.pas(14447): W528 Variable 'Counter' not used in FOR-loop [FixInsight Warning] FLRE.pas(1634): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(1696): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(1697): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(1704): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(1705): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(5757): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(5774): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(5901): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(5922): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6061): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6085): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6236): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6263): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6426): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6456): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6631): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6664): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6851): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(6887): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(7088): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] FLRE.pas(7127): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Optimization] FLRE.pas(2988): O804 Method parameter 'Fallback' is declared but never used [FixInsight Optimization] FLRE.pas(22407): O804 Method parameter 'Error' is declared but never used [FixInsight Warning] pucu.pas(42397): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] pucu.pas(42640): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Warning] pucu.pas(42822): W541 Casting from Integer to Pointer type (or vice versa) [FixInsight Optimization] pucu.pas(41047): O804 Method parameter 'Fallback' is declared but never used