search

BeRo1985 / flre

FLRE - Fast Light Regular Expressions - A fast light regular expression library
GNU Lesser General Public License v2.1
94 stars 23 forks source link

wrong const alignment #85

Closed benibela closed 1 year ago

benibela commented 2 years ago

There are multiple places like

{$if defined(fpc) and (fpc_version>=3)}{$push}{$codealign localmin=16}{$codealign varmin=16}{$ifend}
const XMM1Constant:TXMMValue=(Lo:TFLREQWord($0101010101010101);Hi:TFLREQWord($0101010101010101));

varmin=16 does not do anything here. You need to use constmin=16

see https://gitlab.com/freepascal.org/fpc/source/-/issues/39847#note_1041159728

benibela commented 2 years ago

Now it is actually affecting people: benibela/xidel#93

I made a patch: https://github.com/benibela/flre/commit/3e926d45d4352f1b7c7cd411ccd625df117dad5c