search

BeSimple / BeSimpleSoapClient

NOT MAINTAINED - [READ-ONLY] Subtree split of the BeSimpleSoap -- clone into BeSimple/SoapClient/ (master at BeSimple/BeSimpleSoap)
http://besim.pl/
57 stars 53 forks source link

PHP 8.1 - Deprecation issues #35

Open cslevy opened 1 year ago

cslevy commented 1 year ago

Deprecated function: Return type of BeSimple\SoapClient\SoapClient::getLastRequest() should either be compatible with SoapClient::getLastRequest(): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in include() (line 571

I created a pull request to fix the depraction issues https://github.com/BeSimple/BeSimpleSoapClient/pull/34

JohnG1985 commented 1 year ago

To fix the deprecation issue, you can either update the return type of the BeSimple\SoapClient\SoapClient::getLastRequest() function to match the return type of SoapClient::getLastRequest(), or you can use the #[\ReturnTypeWillChange] attribute to temporarily suppress the deprecation notice. This attribute can be used to indicate that the return type of the function will change in a future version, but that it is still safe to use in the current version.

I hope this helps. Let me know if you have any other questions.

cslevy commented 1 year ago

I know what is the issue. I also fixed it. I created this ticket to link with a pull request, that fixes this issue. Feel free to use it. Hopefully the pull request will be merged into the project.