Compatibility with Symfony master

[stof]

The way to register security factories changed in Symfony master. Instead of asking the end-user to put a link to a file in its security config, each bundle can now register factories in its build method.

To support master, you have 2 choices:

• create different branches. More difficult to maintain if you refactor heavily the bundle but cleaner in the code
• add some tricky logic in build to check if the method is available in the security extension (i.e. you are in master)

What way do you prefer ?

I can provide help for the implementation if you need it.

[jfsimon]

Ah ... I knew it. But I though it was possible in the 2.0 branch (via the container builder), dont you think so ? I guess the best choice is to have different branches, so i'll do like this... an maybe need your help? Thanks for these informations anyway!

[stof]

no, registering factories could only be done via the factories key in the security config (or by editing the SecurityExtension in SecurityBundle to load the file directly from there but it was not an option of course)

Indeed, the cleaner solution could indeed be to use branches.

And the easiest way to maintain both of them IMO is to do what we do in Symfony (and what I use in my own bundle): doing the work in the 2.0 branch (or whatever its name is) and merging it regularly in master. And commits targeting only 2.1 go directly in master.

[pborreli]

hi, any news on this ? this bundle looks great but is not compatible anymore with Symfony 2.1, is it still maintained ?

[jfsimon]

I know, I should work on it. What's broken with 2.1?

[pborreli]

right now i'm blocked with

InvalidConfigurationException: Unrecognized options "trusted_sso" under "security.firewalls.my_firewall"

but i had other problem to fix like :

• include it correctly in my composer.json (would be cool to declare the bundle in packagist)
• this error :

RuntimeException: The definition "security.authentication.listener.trusted_sso" has a reference to an abstract definition "security.authentication.success_handler". Abstract definitions cannot be the target of references.

[jfsimon]

I'll try to fix these errors this week-end.

[pborreli]

thanks very much, count on me to test and report any bug i find (and contribute when i can)

[stof]

@pborreli @jfsimon any news about the update of the bundle ? Btw, it also needs to receive some composer support.

[pborreli]

@stof i started with you so i can push some stuff but i'm stuck with the services/factory order abstract things .. i wanted to use this bundle in my project but finally i'm using CAS directly in apache.

[stof]

@pborreli some friends will need to use the CAS in a Sf2 project, and I don't want them to start their project on 2.0 just because of this. So please push your current work and I will complete it this evening.

[pborreli]

ok will focus on that after work