search

BeWelcome / rox

:earth_africa: BeWelcome lets you share a place to stay, connect with travellers, meet up and find accommodation on your journey. It is and will always be a free, open source, non for profit, democratic community.
https://www.bewelcome.org
GNU General Public License v2.0
188 stars 54 forks source link

Avatar save #244

Closed pschoffer closed 2 years ago

pschoffer commented 3 years ago

This is another step towards having some sort of avatar tweaking tool.

This breaks down avatar change into two steps: 1) Upload the new file 2) Confirm (confirming will move it from temporary space and replace original)

This already brings the value of seeing your new avatar as it will be shown before you confirm the change.

In the next stage, we could add the ability to rotate/crop avatar on the confirm popup.

crumbking commented 3 years ago

Hi @pschoffer, I tested it locally. I confirm that I see a popup with the new profile picture. If I directly change the picture once again the popup does not show up and the pic does not change. But yeah that would be cool to get crop and rotation running....

pschoffer commented 3 years ago

Hi @crumbking , Thanks for giving it a spin!

What do you mean by:

If I directly change the picture once again the popup does not show up and the pic does not change.

Is that expected behavior it sounds like a bug right? Could you provide steps to reproduce, please?

crumbking commented 3 years ago

Sure,

  1. I click on change profile picture and select a new pic
  2. I see: grafik
  3. I click save
  4. Modal get closed and profile picture does not change even if I get a short "toast" message in green "profile pic updated"