BeWelcome / rox

:earth_africa: BeWelcome lets you share a place to stay, connect with travellers, meet up and find accommodation on your journey. It is and will always be a free, open source, non for profit, democratic community.
https://www.bewelcome.org
GNU General Public License v2.0
188 stars 54 forks source link

Use the same Lightbox gallery (with inter-linked images) in the profile's main page than on the gallery page #289

Open nekohayo opened 2 years ago

nekohayo commented 2 years ago

If you go to https://www.bewelcome.org/members/$your_username, at the bottom there is "Latest pictures". However, they are super tiny (please make them bigger instead of having so much padding around the thumbnails!) and when you click on any of them, you are taken to the individual image's page instead of simply zooming into the image with Lightbox and being able to flip through all the images with the Left/Right arrow keys (or the floating arrows you would get in Lightbox if you tell it to show a collection of images). It's slow and cumbersome (you then have to use the browser's back button to see another image, then click again, etc etc.)

I know you already have the Lightbox code for this because that's exactly how it works in https://www.bewelcome.org/gallery/show/user/$your_username/images, so it's a matter of reusing that code directly on the profile page and considering the photos as a linked gallery set (instead of individual images), bringing that UX improvement directly to the profile page, instead of using it only in one hidden place.

thisismeonmounteverest commented 2 years ago

This will be implemented when the profile pages code gets rewritten.

zeuros commented 1 year ago

Did a PR for that, tell me if you can give it a go