search

BeWelcome / rox

:earth_africa: BeWelcome lets you share a place to stay, connect with travellers, meet up and find accommodation on your journey. It is and will always be a free, open source, non for profit, democratic community.
https://www.bewelcome.org
GNU General Public License v2.0
189 stars 53 forks source link

Edit Profile > removing relations does not work (could not add a working Route in LegacyLoader) #81

Closed thisismeonmounteverest closed 5 years ago

thisismeonmounteverest commented 6 years ago

Route isn't the issue but the redirect afterwards.

Couldn't find a good way for that either yet.

ghost commented 5 years ago

Hi, could you describe how to exactly to reproduce (step by step) this issue and how exactly this should work? I'd like to fix it :)

thisismeonmounteverest commented 5 years ago

Login as member-101. Go to your profile and click the edit link on the 'Family and relations'.

ghost commented 5 years ago

Ok, and what is expected result? How should it works?

ghost commented 5 years ago

I reproduce this bug, see screenshot (I don't sure that it is :))

screenshot from 2019-01-01 14-53-01

Or maybe I still have a wrong setup of my dev machine :)

thisismeonmounteverest commented 5 years ago

That's not the expected problem (that is caused by using PHP 7.3 and fixed now).

There are two members with whom member-101 has a relation. The deletion works but the redirect should be to the same page but ends on the landing page (/).

ghost commented 5 years ago

I see, now I can reproduce this bug

screenshot from 2019-01-02 19-31-02

As you wrote, redirection is to main page, what is the proper redirection (for this specific case from this screenshot)?

thisismeonmounteverest commented 5 years ago

The correct redirect would be to the same page so that the user can review the other relations and decide if others need to be removed as well.

amnesiac84 commented 5 years ago

Routes to https://alpha.bewelcome.org//editmyprofile (double // is returning a 404)