search

Beaglefoot / awk-language-server

Language Server for AWK and associated VSCode client extension
https://marketplace.visualstudio.com/items?itemName=beaglefoot.awk-ide-vscode
MIT License
91 stars 5 forks source link

[BUG Fix] Fixes paths which may contains spaces #34

Closed TerminalFi closed 2 years ago

TerminalFi commented 2 years ago

What

Paths which contain spaces break the exec command since the paths are not escaped and they are treated as separate strings.

Beaglefoot commented 2 years ago

@TheSecEng Thanks for providing a fix, but I'd like to avoid adding new dependencies. Could you just revert the last commit and git push -f?

As for prefixes, the current approach uses prettier if it's available on PATH env variable. And this should work on windows as well.

TerminalFi commented 2 years ago

@Beaglefoot will close this. This is the wrong changes ! Sorry

TerminalFi commented 2 years ago

Should be good now

Beaglefoot commented 2 years ago

@TheSecEng Ok let me help you.

You are currently 3 commits ahead of master. These are:

  1. 7e4e62ff88b0171aef7ae38fc1a9cdde984b7c3d
  2. fb6a31d698e9783c0f0cd88c9fb813b19a047c83
  3. b26715cb66d757d7a0f0bd0d94a72c7cd103b490 (the one we are interested in)

To avoid adding unnecessary changes you need to do the following:

  1. git reset --hard b26715cb66d757d7a0f0bd0d94a72c7cd103b490
  2. git push -f

This completely removes the last 2 commits and updates current PR.

TerminalFi commented 2 years ago

Sorry I was a bit out of it yesterday