search

Beaglefoot / awk-language-server

Language Server for AWK and associated VSCode client extension
https://marketplace.visualstudio.com/items?itemName=beaglefoot.awk-ide-vscode
MIT License
90 stars 5 forks source link

Pr snip not work #46

Open Shane-XB-Qian opened 1 year ago

Shane-XB-Qian commented 1 year ago

closes #44

Beaglefoot commented 1 year ago

Looks good. Could you please remove 3 lines mentioned in other comment? And I'll merge.

Shane-XB-Qian commented 1 year ago

remove 3 lines mentioned in other comment

what's that? i did not get you.. :smile:

Shane-XB-Qian commented 1 year ago

you meant not to change snip dict's title which in snippets.json, those 3 lines?

Beaglefoot commented 1 year ago

remove 3 lines mentioned in other comment

what's that? i did not get you.. smile

Totaly forgot to submit review ;)

Shane-XB-Qian commented 1 year ago

and this pr is just trying to solve auto completion for snip from snippets.json but general func/var etc items looks you had to make them to be generated automatically also. // and/or as #45 said, those/you generated items format seems cannot be recognized actually. // and seems you did not impl trigger char feature.

Shane-XB-Qian commented 1 year ago

and did not impl textDocument/signatureHelp feature too. :smile:

Shane-XB-Qian commented 1 year ago

update: the auto-compl cannot work perhaps just #45 the generated fmt was not recognized. // just a guess, no way/yet to verify it.

Shane-XB-Qian commented 1 year ago

@Beaglefoot perhaps either merge this, or give up snip from lsp server side (rollback that previous snip commit), mostly local may have snip plugin already, that's some kinds of dup. // anyway, #45 should be a good enhance when you have time to refine.

Shane-XB-Qian commented 1 year ago

please refer https://github.com/bash-lsp/bash-language-server/pull/897#issuecomment-1623641500