Open justinormont opened 1 month ago
The !this.options.roof.direction should instead check for null/undefined: https://github.com/Beakerboy/OSMBuilding/blob/228874c2e9cfeb80f8619d52591ab5bbe85a1789/src/buildingpart.js#L179
!this.options.roof.direction
null
undefined
In JavaScript, 0 is nullish, causing this warning to be printed, if you set the direction of a skillion roof to 0 (north-facing roof).
0
Since 0 is an acceptable roof direction, no warning should be printed.
Minor, since I think it only causes a warning.
The
!this.options.roof.directionshould instead check fornull/undefined: https://github.com/Beakerboy/OSMBuilding/blob/228874c2e9cfeb80f8619d52591ab5bbe85a1789/src/buildingpart.js#L179In JavaScript,
0is nullish, causing this warning to be printed, if you set the direction of a skillion roof to0(north-facing roof).Expected behavior:
Since
0is an acceptable roof direction, no warning should be printed.Impact:
Minor, since I think it only causes a warning.