Open justinormont opened 1 month ago
Could you add a test for the new cardinal direction code? And one that demonstrates that a building with a north roof does not produce an entry in the error log, but one with a missing direction does?
I submitted a pull request to your branch. Please review it and let me know what you think. I refactored your function to make is shorter and created a unit test for it. It still needs a test for the message in the error log.
Additions:
Fixes:
roof.direction='0'
(north-facing) for skillion roofsCloses https://github.com/Beakerboy/OSMBuilding/issues/60