Closed DrSammie closed 2 years ago
Good catch and thank you for debugging. I have since a while back replaced my VR400 with a VTR300 and these kinds of bugs are hard to find without a physical unit. I added your changes and pushed it to the master branch.
I´m glad that it helped. Thanks again for a great piece of software.
Describe the bug Exhaust temp reading is missing with Systemair VR400
To Reproduce Steps to reproduce the behavior:
Expected behavior To se the exhaust temp displayed and be used.
Additional context I looked back at previous versions of the code of ariana-core.py and found a change in the code that could be the cause of this. Commit 7067b1936c42c15d7ac69629e6bea8749146dcd5, 7 nov 2021 and the changes added to line 816 to 821 I tried to change the code to: " def update_xchanger(self): if len(self.inlet): self.inlet_ave = numpy.average(self.inlet) self.supply_ave = numpy.average(self.supply) self.extract_ave = numpy.average(self.extract) if self.system_name == "VR400": self.exhaust_ave = numpy.average(self.exhaust) else: self.inlet_ave = self.inlet[0] self.supply_ave = self.supply[0] self.extract_ave = self.extract[0]
self.exhaust_ave = self.exhaust[0]
which seems to work, but there is a 2-3 min hang up after the first read but then it seems to be good.
Thank you for a very nice program! And take my comments with the cosideration that my programming experience come from, now 20 years old, school courses with C++ and Mircosoft basics. So my finding and quick fix may be completly wrong and break other stuff ;)
best regards
Samuel