search

BeamCtrl / Airiana

SystemAir Modbus Ventilaton Controller VR400/VR700/VTR300/VSR300/SaveCair
Other
26 stars 7 forks source link

TCP Modbus fixes #7

Closed kromosomX closed 4 years ago

kromosomX commented 4 years ago

A few fixes to get Modbus TCP running. I also moved the setting of the client to airiana-core.py so the recognition of the savecair unit is working.

ghost commented 4 years ago

DeepCode's analysis on #bb9e90 found:

Description Example fixes
Missing close for open, add close or use a with block. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

BeamCtrl commented 4 years ago

Cool, I’ll get to reviewing this during today. Really nice nice to have a collaborator onboard 😀

kromosomX commented 4 years ago

Hi, i’ve been (still am) very busy. I’ll make the necessary changes this or next weekend.

BeamCtrl commented 4 years ago

Cool, no rush, we’re all doing this for fun. If you feel it to much I’ll do it but I feel it may be good for you to be incharge of the TCP feature. Best regards /Daniel