BeamMW / android-wallet

Beam Android Wallet
https://beam.mw
Apache License 2.0
36 stars 21 forks source link

Sync time implementation for Mobile node #576

Closed dariatarakanova closed 2 years ago

dariatarakanova commented 3 years ago

1) Please implement calculating the synchronization time with the blockchain for Mobile node.

2) Remove the additional header line "Loading wallet", leave only secondary text. (see the lowest screenshot with current implementation)

3) Secondary Text: "Syncing with the blockchain: calculating estimated time" "Syncing with the blockchain: X mins to completion" "Syncing with the blockchain: less than a minute to completion" Important: percents should be displayed only in whole numbers (5%, no 5.5%)

New design https://zpl.io/aXygZ6M https://zpl.io/a3QpZAd

image image

The current implementation (for iOS, just as an example, cuz I do not have an android) image

4) Please use such text suggestions for all node types connection

gingervik commented 3 years ago

@Denis-Asipenko please, add examples how it works now

sinaizd commented 3 years ago

At this stage, we cannot calculate the synchronization time with the blockchain if we use a mobile node. The fact is that there is no logic implemented for the mobile node that allows us to return information to the mobile application(our wallet) about how many blocks there will be in total in sync.

sasha-abramovich commented 3 years ago

@Denis-Asipenko Thanks for the helpful explanation, I guess the functionality will be fairly usable, but it's not a small task (as assumed early). We'll rename the task and re-submit. I guess a complementary technical/internal task is required to add the functionality in the infrastructure code. Let me know whether we need to open it.

dariatarakanova commented 3 years ago

The task body was updated with new info

KatsiarynaV commented 2 years ago
  1. When wallet is connected to own node it doesn’t open when node isn’t running 01

  2. Text should be "Syncing with the blockchain" 10

  3. "less than a minute to completion" - "to completion" is duplicated 11 15

KatsiarynaV commented 2 years ago
  1. Cannot create a wallet using mobile node

https://user-images.githubusercontent.com/68267190/159661953-fd952dad-e335-4d8e-a7a9-cbf68a54cb38.mp4

  1. After wallet is created when we go to the node settings screen and then tap the 'back' button the password screen is opened instead of the main wallet screen

https://user-images.githubusercontent.com/68267190/159662178-c380bde0-937a-4395-a912-6dae2b4dfe63.mp4

KatsiarynaV commented 2 years ago

Checked