BeamMW / android-wallet

Beam Android Wallet
https://beam.mw
Apache License 2.0
36 stars 21 forks source link

New addresses: expiration #609

Closed sinaizd closed 2 years ago

sinaizd commented 2 years ago
  1. New address is valid for 2 months. Validity is automatically extended when transaction is received for this address
  2. Add the "Extend" button when editing the address. Address should be extended for 2 months.
sinaizd commented 2 years ago

Need to check:

KatsiarynaV commented 2 years ago
  1. All addresses should be saved with 2 months expiration time. "Extend" should be as button that extend expiration time for 2 months. There should be no such option as "never". Except - default address. This address have expiration time "never" and user can just expire it

  2. Expiration time is extended when we open the edit address screen. But validity should be automatically extended when transaction is received for this address or by clicking "extend" button.

https://user-images.githubusercontent.com/68267190/137322558-0c1559f8-2146-4498-901e-9ae3fc8a066b.mp4

  1. When we send transaction to contact from address book the address should be inserted in a full format (not SBBS)

https://user-images.githubusercontent.com/68267190/137319084-10a32fdf-0fab-4f61-af30-b9f22b1b3a47.mp4

  1. When opening receive screen from address book new token should be generated (inside should be the same SBBS address). And this new token should replace the old one in address book (not create a new address just update) 05

  2. Expiration of address with the active transaction cannot be changed

https://user-images.githubusercontent.com/68267190/137321926-4e55cb95-8a73-48c6-83a4-1f2f34cd1db7.mp4

KatsiarynaV commented 2 years ago
  1. Addresses are saved in the address book with expiration time "never". All addresses except default address should be saved with 2 months expiration time. never

    1. "Extend" button work incorrectly. It extend expiration time to 2 months and 1 hour. When we reopen edit screen the expiration date is changed to correct

https://user-images.githubusercontent.com/68267190/137729230-4137a6e5-b8c4-4c9a-97db-935f314d54a7.mp4

  1. Not fixed - When opening receive screen from address book new token should be generated for address (inside should be the same SBBS address). And this new token should replace the old one in address book (not create a new address just update)
    • create an address in a new format
    • go to the address book
    • open address details and tap Receive button
    • Receive screen is opened and new token is generated
    • go to the address book
    • address is re-saved with new token new token

02

  1. When there is an active transaction for the address, on the edit screen make button "expire now" inactive and add text "There is an active transaction for this address, therefore it cannot be expired."

01

KatsiarynaV commented 2 years ago

Checked