search

BeamMW / beam-ui

Beam Desktop Wallet (Win / Mac / Linux)
https://beam.mw/
Apache License 2.0
27 stars 23 forks source link

[ENHANCEMENT] Create a auto-renew for swap offer duration #1071

Open freQniK opened 8 months ago

freQniK commented 8 months ago

12 hours is the maximum allotted time to offer a swap/atomic swap. This is a very small window. Maybe there can be a function to "auto-renew if not processed" for x amount of times. That way we don't have to keep creating offers every 12 hours and can let it run for a while and forget about it until the offer is accepted or expires after x amount of renews.

Maxnflaxl commented 8 months ago

@anatolse

dbadol commented 4 months ago

I suppose the 12-hour timeframe correspond to the duration SBBS messages are kept by the nodes.

To allow longer swap offers time, we could decide to extend the duration of the SBBS messages. Extending it to 48 hours (by instance) would then also allow longer time-windows for the interactive transactions (which is probably good). And it would also improve the Beam Messenger operation.

The risk would be bloating the nodes with too large a volume of message to keep. But is that really a problem?

On the other hand, if we keep the 12-hour timeframe, an auto-renew function would only work if the wallet is still open at the moment of the renewal (which sort of suppresses the interest of the feature...).

freQniK commented 3 months ago

I was under the impression the swaps would only work if the wallet is open. Is this not the case? This is primarily why I suggested an auto-renew routine

Sent from Proton Mail mobile

-------- Original Message -------- On May 28, 2024, 7:09 PM, dbadol wrote:

I suppose the 12-hour timeframe correspond to the duration SBBS messages are kept by the nodes.

To allow longer swap offers time, we could decide to extend the duration of the SBBS messages. Extending it to 48 hours (by instance) would then also allow longer time-windows for the interactive transactions (which is probably good). And it would also improve the Beam Messenger operation.

The risk would be bloating the nodes with too large a volume of message to keep. But is that really a problem?

On the other hand, if we keep the 12-hour timeframe, an auto-renew function would only work if the wallet is still open at the moment of the renewal (which sort of suppresses the interest of the feature...).

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>