BeamMW / beam-ui

Beam Desktop Wallet (Win / Mac / Linux)
https://beam.mw/
Apache License 2.0
25 stars 23 forks source link

address copied notification triggered, when it shouldnt be #1076

Open Maxnflaxl opened 5 months ago

Maxnflaxl commented 5 months ago

Bug title Address copied notification triggered, when it shouldnt be.

Bug description The "address copied to clipboard" notification popup appears, even when copying strings of variable lenghts, that aren't addresses.

To Reproduce Steps to reproduce the behaviour:

  1. Have wallet open
  2. Try to select and copy the following strings: (checkbox inficates if the notification appears or not)

❌ a ❌ aa ❌ aaa ✔ aaaa ✔ dddd ❌ ddddddddddddddddddddddd ❌ dddddddddddddddddddddddd ✔ dddddddddddddddddddddddddddddddddddddddddd SBBS address for reference: ✔ 99a7ee348c6e31a099e5061123f09a4f9a40bdfb99549e7b1c96b1a167cd1b82f5

Current behaviour The "address copied to clipboard" notification popup appears, even when copying strings of variable lenghts (such as DApp pubkeys(#1070)), that aren't addresses.

Expected behaviour The popup only appears when I copy an address As the different address types are not fixed in length, when we have time, we'll need to make an order in this. Too much ambiguity in this.

Platform and build

Screenshots (if applicable) grafik

Related issues:

1070

665